loader/efi: build with -Wall
ClosedPublic
Actions

Authored by vexeduxr on Sep 8 2025, 9:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 28, 12:42 AM

	Unknown Object (File)
	Thu, Jun 25, 7:53 AM

	Unknown Object (File)
	Wed, Jun 24, 1:24 AM

	Unknown Object (File)
	Sun, Jun 21, 7:21 PM

	Unknown Object (File)
	Sun, Jun 21, 12:14 PM

	Unknown Object (File)
	Thu, Jun 4, 6:25 AM

	Unknown Object (File)
	Jun 1 2026, 8:44 AM

	Unknown Object (File)
	Jun 1 2026, 8:35 AM

View All 71 Files

Subscribers

bcran

dab

Details

Reviewers

imp
kevans
tsoome
jhb
manu

Commits

rGd81b84d6de65: loader/efi: build with -Wall

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Sep 8 2025, 9:02 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 8 2025, 9:02 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

vexeduxr requested review of this revision.Sep 8 2025, 9:02 PM

Harbormaster completed remote builds in B66905: Diff 161743.Sep 8 2025, 9:03 PM

Most errors generated by this are trivial to fix. I just opened reviews for the ones that weren't.

TBH, I would like to see whole loader being built with -Wall (and -Wextra;)

This revision is now accepted and ready to land.Sep 9 2025, 6:49 AM

The BIOS loader uses -Wall, but I'm not sure about the rest.

Closed by commit rGd81b84d6de65: loader/efi: build with -Wall (authored by vexeduxr). · Explain WhySep 9 2025, 5:30 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rGd81b84d6de65: loader/efi: build with -Wall.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

Makefile

1 line

Diff 161816

View Options

loader/efi: build with -WallClosedPublicActions