USB4 acknowledge hotplug events
Needs ReviewPublic
Actions

Authored by obiwac on Mar 22 2025, 1:56 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Nov 16, 9:59 PM

	Unknown Object (File)
	Fri, Nov 14, 12:55 AM

	Unknown Object (File)
	Fri, Nov 7, 4:26 AM

	Unknown Object (File)
	Mon, Nov 3, 9:33 AM

	Unknown Object (File)
	Wed, Oct 29, 9:18 AM

	Unknown Object (File)
	Wed, Oct 29, 9:18 AM

	Unknown Object (File)
	Wed, Oct 29, 8:59 AM

	Unknown Object (File)
	Oct 24 2025, 9:44 AM

View All 61 Files

Subscribers

imp

Details

Reviewers

mohammad_fbsdphab_thelightbird.com
imp
jhb
emaste

Summary

When getting a hotplug event from the hardware, transmit a hotplug acknowledgment packet. This is needed even if we don't do anything with the hotplug events, as the hardware will continuously "spam" us with hotplug events otherwise.

Test Plan

Tested on AMD Pink Sardine controller (1022:1668/9), which is host interface version 1.0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66848
Build 63731: arc lint + arc unit

Event Timeline

obiwac created this revision.Mar 22 2025, 1:56 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 22 2025, 1:56 AM

obiwac requested review of this revision.Mar 22 2025, 1:56 AM

Harbormaster completed remote builds in B63049: Diff 152528.Mar 22 2025, 1:56 AM

obiwac added a parent revision: D49450: USB4 base.Mar 22 2025, 1:56 AM

I want to factor out a notify function first.

obiwac added reviewers: imp, jhb, emaste.Mar 22 2025, 3:23 AM

I'll take a look once you're done with the planned changes you've flagged.

Fixes

Harbormaster completed remote builds in B66848: Diff 161596.Sep 5 2025, 4:59 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

thunderbolt/

router.c

83 lines

tbcfg_reg.h

6 lines

Diff 161596

View Options

sys/dev/thunderbolt/router.c