nda: Only attach to devices whose progif if nvme storage
AcceptedPublic
Actions

Authored by imp on Sep 3 2025, 6:28 PM.

Details

Reviewers

jhb
chuck

Group Reviewers

cam

Summary

There's a number of PCIe cards today that are not, strictly speaking
storage cards. For any PCIe card, make sure that it supports the proper
PCI ProgIF before attaching to it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66791
Build 63674: arc lint + arc unit

Event Timeline

imp created this revision.Sep 3 2025, 6:28 PM

Herald added a reviewer: cam. · View Herald TranscriptSep 3 2025, 6:28 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Sep 3 2025, 6:28 PM

Harbormaster completed remote builds in B66791: Diff 161448.Sep 3 2025, 6:28 PM

imp added a parent revision: D52364: nvme: Use the 'extra' field as the progif field..Sep 3 2025, 6:30 PM

chuck accepted this revision.Mon, Sep 8, 5:12 PM

chuck added a subscriber: chuck.

chuck added inline comments.

sys/cam/nvme/nvme_da.c
678	Would it make sense to log this? No log message for the previous "device is not NVMe" is fine, but here, the code is noticing "this is the wrong kind of NVMe device" feels different (maybe).

This revision is now accepted and ready to land.Mon, Sep 8, 5:12 PM

imp added inline comments.Mon, Sep 8, 8:11 PM

sys/cam/nvme/nvme_da.c
678	I think so, so long as we can have a good error message. It will be rare to see this, so we don't need to rate limit it, and it will happen only with weird, odd-ball cards, which is fine for those users.

Revision Contents
Changeset List

Path

Size

sys/

cam/

nvme/

nvme_da.c

14 lines

Diff 161448

View Options

nda: Only attach to devices whose progif if nvme storageAcceptedPublicActions