Page MenuHomeFreeBSD
Differential D52347

usb: support SSP and SSPx2 xHCI
Needs ReviewPublic
Actions

Authored by aokblast on Sep 2 2025, 6:44 PM.
Tags
Referenced Files
F167279654: D52347.id.diff
Thu, Aug 20, 3:00 PM
Unknown Object (File)
Sat, Aug 8, 2:09 PM
Unknown Object (File)
Sat, Aug 8, 2:07 PM
Unknown Object (File)
Sat, Aug 8, 10:05 AM
Unknown Object (File)
Mon, Aug 3, 7:23 AM
Unknown Object (File)
Mon, Aug 3, 5:19 AM
Unknown Object (File)
Sun, Aug 2, 6:09 AM
Unknown Object (File)
Sun, Jul 26, 6:23 PM
View All 64 Files
Subscribers
imp
lwhsu

Details

Reviewers
adrian
Group Reviewers
USB
Summary

Currently, we only support default PSI id implemented xHCI. For other
xhci, we fallback to 3.0. Note that the total bandwidth of the device
is not so much impacted since all of the setup is done by xHCI
hardware id is compatbile for old xHCI driver.

This driver fix the addressing issue for SSP hub behind a SSP hub and
makes the usb driver detect the speed correctly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 66767
Build 63650: arc lint + arc unit

Event Timeline

aokblast created this revision.Sep 2 2025, 6:44 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 2 2025, 6:44 PM
aokblast requested review of this revision.Sep 2 2025, 6:44 PM
Harbormaster completed remote builds in B66767: Diff 161389.Sep 2 2025, 6:44 PM
imp added inline comments.Sep 2 2025, 10:09 PM
lib/libusb/libusb20_ugen20.c
210

All the lib changes you could do in one commit.

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c
81

You can do this as a separate change, maybe combined with others that just do similar things.

sys/dev/usb/storage/umass.c
2362

These should have their own transfer speeds, I think.

sys/dev/usb/template/usb_template.c
598

2**10 == 1024

602

2**11 is 2048

sys/dev/usb/usb.h
814

You can roll this into the enum... And I'd be tempted to commit just the extra enums first by itself, since that lets you do many slivers of the change on their own as well.

830

Same comment.

sys/dev/usb/usb_hub.c
829

why this change?

lwhsu added a subscriber: lwhsu.Sep 3 2025, 1:30 PM
lwhsu added inline comments.
lib/libusb/libusb01.c
135
lwhsu added inline comments.Sep 3 2025, 2:16 PM
sys/dev/usb/controller/xhci.c
135
544
546
sys/dev/usb/template/usb_template.c
597
601
sys/dev/usb/usb.h
412

usb_devcap_ss_plus_descriptor ?

usr.sbin/usbdump/usbdump.c
165

Do we also need to add USB_SPEED_SUPER_PLUS_X2 ?

lwhsu added a reviewer: USB.Sep 9 2025, 4:22 PM
aokblast updated this revision to Diff 178462.May 23 2026, 10:16 AM
aokblast marked 14 inline comments as done.

Split patches

Harbormaster completed remote builds in B73375: Diff 178462.May 23 2026, 10:16 AM
aokblast retitled this revision from usb: support usb 3.1 (SuperSpeedPlus) and usb 3.2 (SuperSpeedPlus_x2) addressing and display for xhci. to usb: support SSP and SSPx2 xHCI.May 23 2026, 10:16 AM
aokblast added a reviewer: adrian.
aokblast added a project: USB.

Just split the patch with multiple smaller one.

Revision Contents
Changeset List

PathSize
lib/
libusb/
1 line
2 lines
5 lines
1 line
6 lines
sys/
dev/
rtwn/
rtl8812a/
usb/
2 lines
usb/
controller/
12 lines
19 lines
226 lines
14 lines
net/
4 lines
storage/
2 lines
template/
10 lines
63 lines
4 lines
19 lines
189 lines
2 lines
21 lines
8 lines
107 lines
4 lines
2 lines
usr.sbin/
usbconfig/
1 line
usbdump/
1 line

Diff 161389

View Options

lib/libusb/libusb.h

Loading...
View Options

lib/libusb/libusb01.c

Loading...
View Options

lib/libusb/libusb10.c

Loading...
View Options

lib/libusb/libusb20.h

Loading...
View Options

lib/libusb/libusb20_ugen20.c

Loading...
View Options

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c

Loading...
View Options

sys/dev/usb/controller/usb_controller.c

Loading...
View Options

sys/dev/usb/controller/xhci.h

Loading...
View Options

sys/dev/usb/controller/xhci.c

Loading...
View Options

sys/dev/usb/controller/xhcireg.h

Loading...
View Options

sys/dev/usb/net/if_ure.c

Loading...
View Options

sys/dev/usb/storage/umass.c

Loading...
View Options

sys/dev/usb/template/usb_template.c

Loading...
View Options

sys/dev/usb/usb.h

Loading...
View Options

sys/dev/usb/usb_device.c

Loading...
View Options

sys/dev/usb/usb_hub.h

Loading...
View Options

sys/dev/usb/usb_hub.c

Loading...
View Options

sys/dev/usb/usb_hub_private.h

Loading...
View Options

sys/dev/usb/usb_parse.c

Loading...
View Options

sys/dev/usb/usb_request.h

Loading...
View Options

sys/dev/usb/usb_request.c

Loading...
View Options

sys/dev/usb/usb_transfer.c

Loading...
View Options

sys/dev/usb/usbdi_util.h

Loading...
View Options

usr.sbin/usbconfig/dump.c

Loading...
View Options

usr.sbin/usbdump/usbdump.c

Loading...