bsdinstall: Drop outdated comments about ZFS dataset compression
ClosedPublic
Actions

Authored by michaelo on Sun, Aug 31, 10:18 AM.

Details

Reviewers

jrm
otis
ziaee

Commits

rG221a5fb331e1: bsdinstall: Drop outdated comments about ZFS dataset compression
rG7f14cf603e9b: bsdinstall: Drop outdated comments about ZFS dataset compression
rG00a35910b4b0: bsdinstall: Drop outdated comments about ZFS dataset compression
rGf304c5bb8be6: bsdinstall: Drop outdated comments about ZFS dataset compression

Summary

All datasets on zroot pool are compressed by default, no need to mention that
on some specific datasets these days.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66722
Build 63605: arc lint + arc unit

Event Timeline

michaelo created this revision.Sun, Aug 31, 10:18 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptSun, Aug 31, 10:18 AM

michaelo requested review of this revision.Sun, Aug 31, 10:18 AM

Harbormaster completed remote builds in B66709: Diff 161285.Sun, Aug 31, 10:18 AM

You might want to add a refence?

In D52304#1194190, @diizzy wrote:

You might want to add a refence?

You mean https://github.com/freebsd/freebsd-src/blob/fb37e38fbe99039a479520b4b596f4bfc04e2a88/usr.sbin/bsdinstall/scripts/zfsboot#L52-L54?

In D52304#1194191, @michaelo wrote:

In D52304#1194190, @diizzy wrote:

You might want to add a refence?

You mean https://github.com/freebsd/freebsd-src/blob/fb37e38fbe99039a479520b4b596f4bfc04e2a88/usr.sbin/bsdinstall/scripts/zfsboot#L52-L54?

More like historical, this has been the case since the inital commit of zfsboot
https://github.com/freebsd/freebsd-src/blob/cd88b8869f9b2c280b1de02608f52fdf497b4cb1/usr.sbin/bsdinstall/scripts/zfsboot

In D52304#1194192, @diizzy wrote:

In D52304#1194191, @michaelo wrote:

In D52304#1194190, @diizzy wrote:

You might want to add a refence?

You mean https://github.com/freebsd/freebsd-src/blob/fb37e38fbe99039a479520b4b596f4bfc04e2a88/usr.sbin/bsdinstall/scripts/zfsboot#L52-L54?

More like historical, this has been the case since the inital commit of zfsboot
https://github.com/freebsd/freebsd-src/blob/cd88b8869f9b2c280b1de02608f52fdf497b4cb1/usr.sbin/bsdinstall/scripts/zfsboot

Yes and back then only parts were compressed, now everything is compressed and the comments haven't been touched eversince.

This is good with me since compression is stated as a default earlier in the page, but like @diizzy said, a more specific commit message for our readers would be expedient, like:

bsdinstall/zfsboot examples: zap compress comments

Remove compression comments from examples as zroot datasets are compressed by default since FreeBSD 1?.? [0].

[0] {$COMMITID}

This revision is now accepted and ready to land.Sun, Aug 31, 3:59 PM

add ref to default compression

This revision now requires review to proceed.Sun, Aug 31, 6:31 PM

In D52304#1194232, @ziaee wrote:
This is good with me since compression is stated as a default earlier in the page, but like @diizzy said, a more specific commit message for our readers would be expedient, like:
bsdinstall/zfsboot examples: zap compress comments

Remove compression comments from examples as zroot datasets are compressed by default since FreeBSD 1?.? [0].

[0] {$COMMITID}

Done, have a look.

Harbormaster completed remote builds in B66722: Diff 161298.Sun, Aug 31, 6:31 PM

Maintainers, any objections?

jrm accepted this revision.Sat, Sep 6, 6:58 PM

This revision is now accepted and ready to land.Sat, Sep 6, 6:58 PM

Closed by commit rGf304c5bb8be6: bsdinstall: Drop outdated comments about ZFS dataset compression (authored by michaelo). · Explain WhyTue, Sep 9, 10:01 AM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: rGf304c5bb8be6: bsdinstall: Drop outdated comments about ZFS dataset compression.

michaelo added a commit: rG00a35910b4b0: bsdinstall: Drop outdated comments about ZFS dataset compression.Fri, Sep 12, 3:08 PM

michaelo added a commit: rG7f14cf603e9b: bsdinstall: Drop outdated comments about ZFS dataset compression.Fri, Sep 12, 3:24 PM

michaelo added a commit: rG221a5fb331e1: bsdinstall: Drop outdated comments about ZFS dataset compression.Wed, Sep 17, 8:30 PM