Page MenuHomeFreeBSD

bsdinstall: Drop outdated comments about ZFS dataset compression
ClosedPublic

Authored by michaelo on Aug 31 2025, 10:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 2:36 PM
Unknown Object (File)
Fri, Oct 10, 9:55 PM
Unknown Object (File)
Fri, Oct 10, 10:05 AM
Unknown Object (File)
Fri, Oct 10, 10:04 AM
Unknown Object (File)
Fri, Oct 10, 10:04 AM
Unknown Object (File)
Fri, Oct 10, 3:36 AM
Unknown Object (File)
Wed, Oct 1, 5:14 AM
Unknown Object (File)
Wed, Oct 1, 4:06 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You might want to add a refence?

Yes and back then only parts were compressed, now everything is compressed and the comments haven't been touched eversince.

This is good with me since compression is stated as a default earlier in the page, but like @diizzy said, a more specific commit message for our readers would be expedient, like:

bsdinstall/zfsboot examples: zap compress comments

Remove compression comments from examples as zroot datasets are compressed by default since FreeBSD 1?.? [0].

[0] {$COMMITID}
This revision is now accepted and ready to land.Aug 31 2025, 3:59 PM

add ref to default compression

This revision now requires review to proceed.Aug 31 2025, 6:31 PM

This is good with me since compression is stated as a default earlier in the page, but like @diizzy said, a more specific commit message for our readers would be expedient, like:

bsdinstall/zfsboot examples: zap compress comments

Remove compression comments from examples as zroot datasets are compressed by default since FreeBSD 1?.? [0].

[0] {$COMMITID}

Done, have a look.

This revision is now accepted and ready to land.Sep 6 2025, 6:58 PM