Page MenuHomeFreeBSD
Differential D52285

setcred.2: Remove now obsolete mention of setgroups(2)'s different behavior
ClosedPublic
Actions

Authored by olce on Aug 29 2025, 11:05 PM.
Tags
None
Referenced Files
F146751667: D52285.id.diff
Thu, Mar 5, 7:19 AM
Unknown Object (File)
Sun, Mar 1, 7:37 PM
Unknown Object (File)
Sun, Mar 1, 6:01 AM
Unknown Object (File)
Fri, Feb 27, 12:50 AM
Unknown Object (File)
Thu, Feb 26, 11:14 PM
Unknown Object (File)
Thu, Feb 26, 8:19 PM
Unknown Object (File)
Thu, Feb 26, 1:41 PM
Unknown Object (File)
Thu, Feb 26, 12:10 PM
View All 49 Files
Subscribers
emaste
gbe
imp
ziaee

Details

Reviewers
kevans
gbe
Commits
rGaf6ac3228415: setcred.2: Remove now obsolete mention of setgroups(2)'s different behavior
rG66b54c48b2ae: setcred.2: Remove now obsolete mention of setgroups(2)'s different behavior
Summary

Fixes: 9da2fe96ff2e ("kern: fix setgroups(2) and getgroups(2) to match other platforms")
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66688
Build 63571: arc lint + arc unit

Event Timeline

olce created this revision.Aug 29 2025, 11:05 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptAug 29 2025, 11:05 PM
olce requested review of this revision.Aug 29 2025, 11:05 PM
Harbormaster completed remote builds in B66688: Diff 161251.Aug 29 2025, 11:05 PM
gbe accepted this revision.Aug 30 2025, 4:53 AM
gbe added a subscriber: gbe.

LGTM from manpages

This revision is now accepted and ready to land.Aug 30 2025, 4:53 AM
emaste added a comment.Sep 2 2025, 1:57 PM

Do we want some reference to differing behaviour between releases?

olce added a comment.Sep 12 2025, 5:23 PM
In D52285#1194962, @emaste wrote:

Do we want some reference to differing behaviour between releases?

I fear that this would create more confusion, at least if putting it at the point where the text has been removed. Just in case there is some misunderstanding: Only setgroups(2) differ between releases, setcred(2) has stayed the same.

Closed by commit rG66b54c48b2ae: setcred.2: Remove now obsolete mention of setgroups(2)'s different behavior (authored by olce). · Explain WhySep 17 2025, 12:21 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG66b54c48b2ae: setcred.2: Remove now obsolete mention of setgroups(2)'s different behavior.
olce added a commit: rGaf6ac3228415: setcred.2: Remove now obsolete mention of setgroups(2)'s different behavior.Sep 23 2025, 12:04 PM

Revision Contents
Changeset List

PathSize
lib/
libsys/
7 lines

Diff 161251

View Options

lib/libsys/setcred.2

Loading...