amd64 vmx: micro-optimize vmlaunch failure path
ClosedPublic
Actions

Authored by kib on Aug 23 2025, 12:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 17, 9:34 AM

	Unknown Object (File)
	Sun, May 17, 6:54 AM

	Unknown Object (File)
	Sat, May 16, 10:53 PM

	Unknown Object (File)
	Sat, May 16, 4:06 PM

	Unknown Object (File)
	Thu, May 14, 4:22 PM

	Unknown Object (File)
	Thu, May 14, 2:36 PM

	Unknown Object (File)
	Thu, May 14, 1:22 PM

	Unknown Object (File)
	Thu, May 14, 8:36 AM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG2b35b717188a: amd64 vmx: micro-optimize vmlaunch failure path

Summary

Eliminate two unneeded jumps.  One is the jmp to the next instruction,
where there is no requrement that vmlaunch is followed by jmp.  Another
one conditionally sets %r11d value, and can be replaced by cmovcc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 23 2025, 12:55 PM

Herald added a reviewer: bhyve. · View Herald TranscriptAug 23 2025, 12:55 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

kib requested review of this revision.Aug 23 2025, 12:55 PM

Restore the label.

markj accepted this revision as: markj.Aug 24 2025, 4:24 PM

This revision is now accepted and ready to land.Aug 24 2025, 4:24 PM

Closed by commit rG2b35b717188a: amd64 vmx: micro-optimize vmlaunch failure path (authored by kib). · Explain WhyAug 24 2025, 7:21 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG2b35b717188a: amd64 vmx: micro-optimize vmlaunch failure path.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

intel/

vmx_support.S

8 lines

Diff 160904

View Options

sys/amd64/vmm/intel/vmx_support.S

amd64 vmx: micro-optimize vmlaunch failure pathClosedPublicActions