Paths

Table of Contentst

Differential D49182

watchdog: Add a new "Control" ioctl
ClosedPublic
Actions

Authored by jhibbits on Feb 28 2025, 6:55 PM.

Tags

None

Referenced Files

	F150773837: D49182.id.diff
	Fri, Apr 3, 11:30 PM

	Unknown Object (File)
	Fri, Apr 3, 2:52 AM

	Unknown Object (File)
	Sun, Mar 29, 11:01 AM

	Unknown Object (File)
	Sat, Mar 28, 12:42 AM

	Unknown Object (File)
	Wed, Mar 11, 6:29 AM

	Unknown Object (File)
	Tue, Mar 10, 2:32 PM

	Unknown Object (File)
	Sat, Mar 7, 8:46 PM

	Unknown Object (File)
	Sat, Mar 7, 12:04 PM

View All 80 Files

Subscribers

Details

Reviewers

jhb
imp
phk
stevek

Commits

rG69f7d6912a24: watchdog: Add a new "Control" ioctl

Summary

In preparation for a new watchdog timeout interface using sbintime_t,
add a new control ioctl to arm, pat, and disarm the watchdog.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66033
Build 62916: arc lint + arc unit

Event Timeline

jhibbits created this revision.Feb 28 2025, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2025, 6:55 PM

jhibbits requested review of this revision.Feb 28 2025, 6:55 PM

Harbormaster completed remote builds in B62696: Diff 151696.Feb 28 2025, 6:55 PM

jhibbits added reviewers: jhb, imp, phk, stevek.Feb 28 2025, 7:00 PM

jhibbits mentioned this in D47312: watchdog: Convert to using sbintime_t format.

jlduran added a subscriber: jlduran.Mar 2 2025, 10:13 PM

I'm fine with this.

This revision is now accepted and ready to land.Mar 12 2025, 7:52 PM

jhb added inline comments.Mar 13 2025, 4:02 PM

sys/dev/watchdog/watchdog.c
128	Do you mean to call it twice back to back with the same arguments if both `RESET` and `ENABLE` are set?

jhibbits added inline comments.Apr 29 2025, 3:13 AM

sys/dev/watchdog/watchdog.c
128	No, I intended to make it an else if here (might need to do more work in one of them, but haven't decided if I do, so keeping them separate). Will fix.

Address @jhb's feedback.

This revision now requires review to proceed.Aug 6 2025, 8:39 PM

Harbormaster completed remote builds in B66033: Diff 159901.Aug 6 2025, 8:39 PM

jhb accepted this revision.Aug 14 2025, 5:05 PM

This revision is now accepted and ready to land.Aug 14 2025, 5:05 PM

Closed by commit rG69f7d6912a24: watchdog: Add a new "Control" ioctl (authored by jhibbits). · Explain WhyAug 14 2025, 7:03 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rG69f7d6912a24: watchdog: Add a new "Control" ioctl.

Revision Contents
Changeset List

Path

Size

sys/

dev/

watchdog/

20 lines

sys/

8 lines

usr.sbin/

watchdogd/

13 lines

Diff 159901

sys/dev/watchdog/watchdog.c

Loading...

sys/sys/watchdog.h

Loading...

usr.sbin/watchdogd/watchdogd.c

Loading...