libsys: add a dependency for syscall stubs
ClosedPublic
Actions

Authored by brooks on Fri, Aug 1, 12:38 PM.

Details

Reviewers

kib
imp
emaste

Commits

rG401d39e38937: libsys: add a dependency for syscall stubs

Summary

Make syscall stubs generated by lib/libsys/Makefile.sys depend on it.
This is slightly overkill, but generating and assembling them is fast.

While here, fix the comment documenting their origin.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65890
Build 62773: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Fri, Aug 1, 12:38 PM

brooks created this revision.

Harbormaster completed remote builds in B65885: Diff 159544.Fri, Aug 1, 12:38 PM

Then why not list other includes like compat.h and SYS.h as deps?

This revision is now accepted and ready to land.Fri, Aug 1, 1:07 PM

Add dependencies on compat.h and SYS.h

This revision now requires review to proceed.Fri, Aug 1, 1:45 PM

Harbormaster completed remote builds in B65890: Diff 159557.Fri, Aug 1, 1:45 PM

emaste accepted this revision.Fri, Aug 1, 2:01 PM

emaste added inline comments.

lib/libsys/Makefile.sys
138	generated assembly?
140	I think it's worth clarifying "somewhat overkill" - it's just that we'll also regenerate on Makefile or compat.h/SYS.h changes that don't actually affect the output presumably

This revision is now accepted and ready to land.Fri, Aug 1, 2:01 PM

kib accepted this revision.Fri, Aug 1, 2:59 PM

Closed by commit rG401d39e38937: libsys: add a dependency for syscall stubs (authored by brooks). · Explain WhyWed, Aug 6, 12:52 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG401d39e38937: libsys: add a dependency for syscall stubs.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

Makefile.sys

20 lines

Diff 159557

View Options

libsys: add a dependency for syscall stubsClosedPublicActions