Page MenuHomeFreeBSD

committers-guide: increase subject length limit to 67 characters
ClosedPublic

Authored by emaste on Dec 29 2024, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 13, 8:35 AM
Unknown Object (File)
Sun, Nov 9, 12:34 AM
Unknown Object (File)
Sat, Nov 8, 10:04 PM
Unknown Object (File)
Wed, Oct 29, 7:42 PM
Unknown Object (File)
Oct 15 2025, 9:31 PM
Unknown Object (File)
Oct 11 2025, 6:11 PM
Unknown Object (File)
Oct 8 2025, 9:13 PM
Unknown Object (File)
Oct 2 2025, 11:03 PM
Subscribers

Details

Summary
I originally suggested a 63-character limit "so that git log --oneline
avoids wrapping".  Short hashes in the tree are typically 12 characters.
With a space between the hash and the subject should result in a limit
of 67 characters.  I think I arrived at 63 by subtracting git's typical
4-space indentation, but that's not applicable to `git log --oneline`.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

btw, I got this script. Named wrap74, it would wrap lines to 74 chars. And you can have several symlinks/hardlinks for it, with different names, e.g. wrap79, wrap64.

#!/usr/local/bin/python

import fileinput
import textwrap
import os
import re

len = int(re.search('[0-9]+$', os.path.basename(__file__)).group())

all = ''
for line in fileinput.input():
        if (line == '\n'):
                print(textwrap.fill(all, len))
                print()
                all = ''
        else:
                all += line

print(textwrap.fill(all, len))
This revision is now accepted and ready to land.Jul 31 2025, 2:04 PM