bsdinstall: use the canonical name for compression
ClosedPublic
Actions

Authored by ivy on Jul 27 2025, 1:29 PM.

Details

Reviewers

leres
delphij

Group Reviewers

Installer
ZFS

Commits

rG8174561013b3: bsdinstall: use the canonical name for compression
rG16045420e7f8: bsdinstall: use the canonical name for compression

Summary

According to zfsprops(7), the canonical property for the compression
algorithm is "compression", with "compress" accepted as an alternate
name. Use the canonical name in bsdinstall.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65777
Build 62660: arc lint + arc unit

Event Timeline

ivy created this revision.Jul 27 2025, 1:29 PM

Herald added subscribers: ziaee, jrtc27, imp. · View Herald TranscriptJul 27 2025, 1:29 PM

ivy requested review of this revision.Jul 27 2025, 1:29 PM

Harbormaster completed remote builds in B65770: Diff 159229.Jul 27 2025, 1:29 PM

I think it makes sense to just leave compression to on (use the default, which is lz4 for the current ZFS version) instead of explicitly saying lz4 here because that would be more future proof. The change looks otherwise fine to me.

This revision is now accepted and ready to land.Jul 27 2025, 6:57 PM

use 'on' instead of 'lz4'

This revision now requires review to proceed.Jul 27 2025, 7:12 PM

Harbormaster completed remote builds in B65777: Diff 159246.Jul 27 2025, 7:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 28 2025, 12:46 PM

Closed by commit rG16045420e7f8: bsdinstall: use the canonical name for compression (authored by ivy). · Explain Why

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG16045420e7f8: bsdinstall: use the canonical name for compression.

ivy added a commit: rG8174561013b3: bsdinstall: use the canonical name for compression.Aug 23 2025, 12:12 AM