Page MenuHomeFreeBSD
Differential D51225

libusb: implement libusb_get_max_alt_packet_size
Needs ReviewPublic
Actions

Authored by aokblast on Jul 9 2025, 10:51 AM.
Tags
None
Referenced Files
F152807481: D51225.id158216.diff
Fri, Apr 17, 6:03 AM
Unknown Object (File)
Tue, Apr 14, 1:22 PM
Unknown Object (File)
Sat, Apr 11, 12:50 AM
Unknown Object (File)
Sun, Apr 5, 2:38 PM
Unknown Object (File)
Thu, Mar 26, 1:38 AM
Unknown Object (File)
Feb 20 2026, 8:42 PM
Unknown Object (File)
Feb 19 2026, 12:35 PM
Unknown Object (File)
Feb 1 2026, 5:34 PM
View All 84 Files
Subscribers
imp
lwhsu
unitrunker_unitrunker.net
ziaee

Details

Reviewers
bapt
kevans
Group Reviewers
USB
manpages
Summary

The libusb has a function to calculate the size from given interface,
alt_setting, endpoint. Implementing it by refactoring the calculating
function for libusb_get_max_iso_packet_size.

Sponsored By: FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 65298
Build 62181: arc lint + arc unit

Event Timeline

aokblast created this revision.Jul 9 2025, 10:51 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJul 9 2025, 10:51 AM
aokblast requested review of this revision.Jul 9 2025, 10:51 AM
Harbormaster completed remote builds in B65298: Diff 158214.Jul 9 2025, 10:51 AM
aokblast added reviewers: bapt, USB, kevans.Jul 9 2025, 10:51 AM
aokblast updated this revision to Diff 158216.Jul 9 2025, 11:36 AM

Add missing parentheses in return

Harbormaster completed remote builds in B65300: Diff 158216.Jul 9 2025, 11:36 AM
aokblast updated this revision to Diff 160314.Aug 14 2025, 3:26 AM

Rebase to main and fix potential error

Harbormaster completed remote builds in B66218: Diff 160314.Aug 14 2025, 3:26 AM
lwhsu added a subscriber: lwhsu.Aug 14 2025, 5:21 PM
lwhsu added inline comments.
lib/libusb/libusb10.c
592

pdconf seems leaked here.

612

for all the early return below, except the if (ret < 0), pdconf needs being free()'d?

aokblast updated this revision to Diff 160364.Aug 14 2025, 6:02 PM

leaks

Harbormaster completed remote builds in B66244: Diff 160364.Aug 14 2025, 6:02 PM
lwhsu added inline comments.Aug 23 2025, 1:32 AM
lib/libusb/libusb.3
193

do you mean multiply the multiplier?

unitrunker_unitrunker.net added a subscriber: unitrunker_unitrunker.net.Dec 16 2025, 5:16 PM
unitrunker_unitrunker.net added inline comments.
lib/libusb/libusb.3
190

Returns the packet size on success,

ziaee added a reviewer: manpages.Dec 16 2025, 5:35 PM

Revision Contents
Changeset List

PathSize
lib/
libusb/
11 lines
7 lines
148 lines

Diff 158214

View Options

lib/libusb/libusb.h

Loading...
View Options

lib/libusb/libusb.3

Loading...
View Options

lib/libusb/libusb10.c

Loading...