Page MenuHomeFreeBSD

lockf: minor cosmetic cleanups, no functional change
AcceptedPublic

Authored by kevans on Tue, Jun 24, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 8:12 PM
Unknown Object (File)
Thu, Jul 3, 4:24 PM
Unknown Object (File)
Thu, Jul 3, 6:38 AM
Unknown Object (File)
Sat, Jun 28, 6:08 AM
Subscribers

Details

Reviewers
allanjude
des
kib
Summary

Switch various flags from int -> bool.

kill(getpid(), foo) and raise(foo) are equivalent in this context, so
switch to the latter as a minor preference for readability.

Use proper signal fences instead of volatile for our SIGAALRM handler.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65094
Build 61977: arc lint + arc unit

Event Timeline

kevans added a subscriber: kib.

Adding @kib to validate fence usage.

This revision is now accepted and ready to land.Tue, Jun 24, 11:41 PM
usr.bin/lockf/lockf.c
65–66
134–135

this is ugly, I would hoist errstr to function scope and drop the braces.

228
230
kevans marked 4 inline comments as done.

Address review feedback

This revision now requires review to proceed.Thu, Jun 26, 3:03 AM
This revision is now accepted and ready to land.Tue, Jul 1, 10:51 AM