Page MenuHomeFreeBSD
Differential D51026

lockf: tests: add tests for the -p and -T features
ClosedPublic
Actions

Authored by kevans on Jun 24 2025, 11:19 PM.
Tags
None
Referenced Files
F154619950: D51026.id158018.diff
Wed, Apr 29, 1:34 AM
F154618122: D51026.id158018.diff
Wed, Apr 29, 1:29 AM
F154398160: D51026.diff
Tue, Apr 28, 8:31 AM
Unknown Object (File)
Tue, Apr 28, 12:53 AM
Unknown Object (File)
Mon, Apr 20, 12:13 AM
Unknown Object (File)
Sun, Apr 19, 12:51 PM
Unknown Object (File)
Sun, Apr 19, 12:51 PM
Unknown Object (File)
Sun, Apr 19, 11:17 AM
View All 72 Files
Subscribers
imp

Details

Reviewers
allanjude
des
Commits
rGc82203e65d08: lockf: tests: add tests for the -p and -T features

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jun 24 2025, 11:19 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 24 2025, 11:19 PM
kevans requested review of this revision.Jun 24 2025, 11:19 PM
Harbormaster completed remote builds in B65066: Diff 157556.Jun 24 2025, 11:19 PM
kevans added a parent revision: D51025: lockf: add a -T option to terminate the child upon early abort.Jun 24 2025, 11:19 PM
kevans added a child revision: D51027: lockf: minor cosmetic cleanups, no functional change.Jun 24 2025, 11:21 PM
des requested changes to this revision.Jul 1 2025, 10:50 AM
des added inline comments.
usr.bin/lockf/tests/lockf_test.sh
230
231
251
252
296

what's the point of capturing stdout here?

297

what's the point of capturing stdout here?

312
This revision now requires changes to proceed.Jul 1 2025, 10:50 AM
kevans marked an inline comment as done.Jul 1 2025, 12:55 PM
kevans added inline comments.
usr.bin/lockf/tests/lockf_test.sh
296

save captures, file checks. these are both ensuring that we're only getting back the single pid.

des added inline comments.Jul 1 2025, 1:36 PM
usr.bin/lockf/tests/lockf_test.sh
296

oh, I misread

kevans updated this revision to Diff 158018.Jul 5 2025, 5:00 PM
kevans marked 6 inline comments as done.

Address typos and other review feedback

Harbormaster completed remote builds in B65225: Diff 158018.Jul 5 2025, 5:00 PM
des accepted this revision.Jul 10 2025, 4:44 PM

only nits left

usr.bin/lockf/tests/lockf_test.sh
37

consider making this (and cur and tmo) local

This revision is now accepted and ready to land.Jul 10 2025, 4:44 PM
des added inline comments.Jul 10 2025, 4:45 PM
usr.bin/lockf/tests/lockf_test.sh
36

phab won't let me post this edit suggestion without a comment 🙄

289

phab won't let me post this edit suggestion without a comment 🙄

kevans marked 3 inline comments as done.Jul 10 2025, 5:52 PM
Closed by commit rGc82203e65d08: lockf: tests: add tests for the -p and -T features (authored by kevans). · Explain WhyJul 10 2025, 5:55 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGc82203e65d08: lockf: tests: add tests for the -p and -T features.

Revision Contents
Changeset List

PathSize
usr.bin/
lockf/
tests/
95 lines

Diff 158268

View Options

usr.bin/lockf/tests/lockf_test.sh

Loading...