Paths

Table of Contentst

Differential D51041

contrib/llvm-project: fix clang crash compiling modules
ClosedPublic
Actions

Authored by ivy on Wed, Jun 25, 4:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 1, 10:05 AM

	Unknown Object (File)
	Sun, Jun 29, 10:37 PM

Subscribers

Details

Reviewers

des
kevans
dim
brooks

Commits

rGfbaab1373280: contrib/llvm-project: fix clang crash compiling modules
rGa443333f9bb4: contrib/llvm-project: fix clang crash compiling modules
rG55dfaeae8e9a: contrib/llvm-project: fix clang crash compiling modules

Summary

clang++ may crash when compiling certain C++20 modules. Backport the
fix from LLVM upstream.

This fixes LLVM bug 102684:
https://github.com/llvm/llvm-project/issues/102684.

PR: 287803
Obtained from: https://github.com/llvm/llvm-project/pull/102855

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65083
Build 61966: arc lint + arc unit

Event Timeline

ivy created this revision.Wed, Jun 25, 4:02 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 25, 4:02 PM

ivy requested review of this revision.Wed, Jun 25, 4:02 PM

Harbormaster completed remote builds in B65083: Diff 157604.Wed, Jun 25, 4:02 PM

Can you put a MFC after: 3 days header in the commit message, please? (I tend to use 3 days for upstream commits that are trivial; this one seems a bit more extensive so maybe you can extend the MFC period to one or two weeks)

This revision is now accepted and ready to land.Wed, Jun 25, 4:47 PM

In D51041#1164931, @dim wrote:

Can you put a MFC after: 3 days header in the commit message, please?

i've added 3 days to my local commit message. i've tested this with buildworld and with the commit that produced the problem, and it's in a fairly niche feature (C++20 modules) so i'm happy with 3 days personally, but i could do longer if you think it's appropriate.

3 days is fine, if it works. :)

kevans accepted this revision.Wed, Jun 25, 5:09 PM

Closed by commit rG55dfaeae8e9a: contrib/llvm-project: fix clang crash compiling modules (authored by ivy). · Explain WhyWed, Jun 25, 5:14 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG55dfaeae8e9a: contrib/llvm-project: fix clang crash compiling modules.

ivy added a commit: rGa443333f9bb4: contrib/llvm-project: fix clang crash compiling modules.Sun, Jun 29, 9:00 PM

ivy added a commit: rGfbaab1373280: contrib/llvm-project: fix clang crash compiling modules.Mon, Jun 30, 11:21 PM

Revision Contents
Changeset List

Path

Size

contrib/

llvm-project/

clang/

include/

clang/

Frontend/

MultiplexConsumer.h

1 line

Serialization/

ASTDeserializationListener.h

2 lines

3 lines

1 line

lib/

Frontend/

MultiplexConsumer.cpp

5 lines

Serialization/

91 lines

6 lines

Diff 157604

contrib/llvm-project/clang/include/clang/Frontend/MultiplexConsumer.h

Loading...

contrib/llvm-project/clang/include/clang/Serialization/ASTDeserializationListener.h

Loading...

contrib/llvm-project/clang/include/clang/Serialization/ASTReader.h

Loading...

contrib/llvm-project/clang/include/clang/Serialization/ASTWriter.h

Loading...

contrib/llvm-project/clang/lib/Frontend/MultiplexConsumer.cpp

Loading...

contrib/llvm-project/clang/lib/Serialization/ASTReader.cpp

Loading...

contrib/llvm-project/clang/lib/Serialization/ASTWriter.cpp

Loading...