Differential D50978

dev/psci: Check for functions before calling
ClosedPublic
Actions

Authored by andrew on Jun 23 2025, 12:46 PM.

Details

Reviewers

Group Reviewers

arm64

Commits

rG288ba78edcfd: dev/psci: Check for functions before calling

Summary

In the SMCCC TRNG and Errata ABI drivers check if the version
functions are implemented before calling them. Without this the firmware
may complain about an unimplemented function being called.

Reported by: bz
Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 23 2025, 12:46 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2025, 12:46 PM

andrew requested review of this revision.Jun 23 2025, 12:46 PM

Harbormaster completed remote builds in B65025: Diff 157448.Jun 23 2025, 12:46 PM

andrew added a parent revision: D50977: dev/psci: Use an SMCCC return value.Jun 23 2025, 12:46 PM

andrew added a child revision: D50979: dev/psci: Use the correct SMCCC TRNG field.

mikael added a subscriber: mikael.Jun 23 2025, 2:11 PM

mikael added inline comments.

sys/dev/psci/smccc_errata.c
73–74	typo -> check

The warnings are gone but does that also mean that if ATF doesn't support the bits any errata are not dealt with silently now?

If the firmware doesn't implement the Errata ABI then we may enable a workaround in the kernel even if we don't need to, e.g. when the firmware already has a workaround, or the combination of HW means it's not needed

Accepted assuming you'll fix the typo in the comment before commit.

This revision is now accepted and ready to land.Jun 24 2025, 8:32 PM

Closed by commit rG288ba78edcfd: dev/psci: Check for functions before calling (authored by andrew). · Explain WhyJun 25 2025, 11:23 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG288ba78edcfd: dev/psci: Check for functions before calling.