linuxkpi: Define `div64_ul()` as a synonym to `div64_u64()`
ClosedPublic
Actions

Authored by dumbbell on Jun 23 2025, 9:31 PM.

Details

Reviewers

Group Reviewers

linuxkpi

Commits

rGcf16d65c2e3a: linuxkpi: Define `div64_ul()` as a synonym to `div64_u64()`

Summary

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Jun 23 2025, 9:31 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 23 2025, 9:31 PM

dumbbell requested review of this revision.Jun 23 2025, 9:31 PM

bz added a subscriber: bz.Jun 23 2025, 9:34 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/math64.h
74	Why do you put it here and not under div64_u64()?

dumbbell marked an inline comment as done.Jun 23 2025, 9:48 PM

dumbbell added inline comments.

sys/compat/linuxkpi/common/include/linux/math64.h
74	Hmm, you are right, it would be better just after `div64_u64()`. I guess I put it after all the existing `div64_u*()` functions.

Address comment from @bz: move the definition of div64_ul() just after div64_u64().

bz accepted this revision.Jun 23 2025, 10:07 PM

This revision is now accepted and ready to land.Jun 23 2025, 10:07 PM

Closed by commit rGcf16d65c2e3a: linuxkpi: Define `div64_ul()` as a synonym to `div64_u64()` (authored by dumbbell). · Explain WhyJun 23 2025, 10:33 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGcf16d65c2e3a: linuxkpi: Define `div64_ul()` as a synonym to `div64_u64()`.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

math64.h

2 lines

Diff 157481

View Options

sys/compat/linuxkpi/common/include/linux/math64.h

linuxkpi: Define `div64_ul()` as a synonym to `div64_u64()`ClosedPublicActions