Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 65002 Build 61885: arc lint + arc unit
Event Timeline
@kevans Do you think we should show IADs inside usbconfig? If so, what is your opinion about the format? IAD is a structure that cover multiple interfaces into 1 usb function. In that case, all interface should have a new indent and put the IAD on the top of It.
| lib/libusb/libusb.3 | ||
|---|---|---|
| 512 | ||
| 524 | ||
| lib/libusb/libusb.h | ||
| 79 | Let's have this sorting enum member change in another commit, also, it seems that LIBUSB_DT_BOS should be placed after LIBUSB_DT_INTERFACE_ASSOCIATION ? | |
| lib/libusb/libusb10_desc.c | ||
| 736 | This config will not be free()'d in the following early return:
| |
| 789 | Maybe calling the parameter iad_arr to match the definition of libusb_get_active_interface_association_descriptors? Or, even align more with libusb_get_interface_association_descriptors to be called iad_array? | |
| 791 | Do we need to check desc is not null first? | |
| lib/libusb/libusb20_desc.h | ||
| 260 | From the spec, iFunction seems using UINT8_T? | |
in man page and code, there are iad_array and iad_arr, would be nice if this naming can be consistent.
| lib/libusb/libusb.3 | ||
|---|---|---|
| 534 | ||
| 535 | ||
| lib/libusb/libusb10_desc.c | ||
| 742 | Does this also mean success? If so, should we set iad_arr = NULL to prevent that caller still pass the returned iad_arr to free() ? | |
| lib/libusb/libusb20_desc.h | ||
| 259 | is this bInterfaceProtocol only in LIBUSB20_INTERFACE_DESC but not in LIBUSB20_INTERFACE_ASSOCIATION_DESC? | |
| lib/libusb/libusb.h | ||
|---|---|---|
| 276 | It seems that we already have this in line 316? | |