Page MenuHomeFreeBSD
Differential D50774

*/*: Rename WEBSOCKET option
ClosedPublic
Actions

Authored by michaelo on Tue, Jun 10, 9:22 AM.
Tags
None
Referenced Files
F121953330: D50774.id156775.diff
Mon, Jun 30, 11:11 PM
Unknown Object (File)
Sun, Jun 29, 4:05 PM
Unknown Object (File)
Sun, Jun 29, 4:51 AM
Unknown Object (File)
Sat, Jun 28, 9:56 AM
Unknown Object (File)
Tue, Jun 17, 8:11 AM
Unknown Object (File)
Sun, Jun 15, 8:38 PM
Unknown Object (File)
Sun, Jun 15, 8:38 PM
Unknown Object (File)
Sun, Jun 15, 8:34 PM
View All 16 Files
Subscribers
None

Details

Reviewers
jrm
otis
AMDmi3
Summary

The WEBSOCKETS option has been renamed to WEBSOCKET to match the name from
RFC 6455, other ports and the description from Mk/bsd.options.desc.mk.

Approved by: jrm (mentor), otis (mentor), amdmi3

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64842
Build 61725: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Tue, Jun 10, 9:22 AM
michaelo created this revision.
Harbormaster completed remote builds in B64739: Diff 156775.Tue, Jun 10, 9:22 AM
otis added a comment.Tue, Jun 10, 9:25 AM

Couldn't be WEBSOCKETS also left in place, with the same LIB_DEPENDS and CMAKE_ON as WEBSOCKET, to lower the POLA violation, for some time?

michaelo added a comment.Tue, Jun 10, 9:33 AM
In D50774#1158748, @otis wrote:

Couldn't be WEBSOCKETS also left in place, with the same LIB_DEPENDS and CMAKE_ON as WEBSOCKET, to lower the POLA violation, for some time?

How is the user supported to maintain two options w/o knowing the new one? I am not fully sure that I do understand your proposal.

We didn't do it here: 9537b429308c

otis accepted this revision.Tue, Jun 10, 9:37 AM

Then LGTM!

This revision is now accepted and ready to land.Tue, Jun 10, 9:37 AM
michaelo added a comment.Tue, Jun 10, 10:15 AM

I'll keep this open for a couple of more days to review.

michaelo updated this revision to Diff 156962.Fri, Jun 13, 11:47 AM

Rebase

This revision now requires review to proceed.Fri, Jun 13, 11:47 AM
Harbormaster completed remote builds in B64842: Diff 156962.Fri, Jun 13, 11:47 AM
jrm accepted this revision.Tue, Jun 17, 3:46 PM
jrm added inline comments.
UPDATING
13

The ulimate nit-picky comment: serial comma for the win.

This revision is now accepted and ready to land.Tue, Jun 17, 3:46 PM
michaelo closed this revision.Fri, Jun 20, 10:21 PM

Merged with e4109927e2608347ccdd0667efe02cd8a7fc555e already.

Revision Contents
Changeset List

PathSize
7 lines
devel/
py-gql/
8 lines
games/
DDNet/
9 lines
net/
mosquitto/
10 lines

Diff 156962

View Options

UPDATING

Loading...
View Options

devel/py-gql/Makefile

Loading...
View Options

games/DDNet/Makefile

Loading...
View Options

net/mosquitto/Makefile

Loading...