Differential D50588

style: Use static consistently
ClosedPublic
Actions

Authored by imp on Wed, May 28, 9:49 PM.

Tags

None

Referenced Files

	F119753034: D50588.id156308.diff
	Wed, Jun 11, 8:46 PM

	F119741702: D50588.id156235.diff
	Wed, Jun 11, 6:19 PM

	Unknown Object (File)
	Mon, Jun 9, 11:24 PM

	Unknown Object (File)
	Mon, Jun 9, 12:30 AM

	Unknown Object (File)
	Sun, Jun 8, 8:16 PM

	Unknown Object (File)
	Sun, Jun 1, 7:16 AM

	Unknown Object (File)
	Fri, May 30, 5:10 PM

Subscribers

Details

Reviewers

chs
kevans
jhibbits
tsoome
manu

Commits

rGaeb446be4ea2: style: Use static consistently

Summary

C doesn't require that we have static on both the declaration and
definition of a function. But stylistically, FreeBSD does. Make that
so. Also make a function static that wasn't because, it seems, that
static and struct look a lot alike in a column of text.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64537
Build 61421: arc lint + arc unit

Event Timeline

imp created this revision.Wed, May 28, 9:49 PM

Herald added a reviewer: manu. · View Herald TranscriptWed, May 28, 9:49 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Wed, May 28, 9:49 PM

Harbormaster completed remote builds in B64519: Diff 156235.Wed, May 28, 9:49 PM

imp added a parent revision: D50587: stand: Retire arch_loadaddr, pending its replacement.Wed, May 28, 9:49 PM

imp added a child revision: D50589: kboot: Create quit command.

jhibbits accepted this revision.Thu, May 29, 12:57 PM

This revision is now accepted and ready to land.Thu, May 29, 12:57 PM

Update per review

This revision now requires review to proceed.Thu, May 29, 6:18 PM

Harbormaster completed remote builds in B64537: Diff 156266.Thu, May 29, 6:18 PM

tsoome accepted this revision.Fri, May 30, 6:49 AM

This revision is now accepted and ready to land.Fri, May 30, 6:49 AM

Closed by commit rGaeb446be4ea2: style: Use static consistently (authored by imp). · Explain WhyFri, May 30, 3:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGaeb446be4ea2: style: Use static consistently.

Revision Contents
Changeset List

Path

Size

stand/

common/

8 lines

Diff 156266

stand/common/module.c

Loading...