Differential D50555

ifconfig: 802.11: factor out keyix printing
ClosedPublic
Actions

Authored by bz on May 27 2025, 8:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 13, 7:29 PM

	Unknown Object (File)
	Thu, Aug 13, 10:28 AM

	Unknown Object (File)
	Thu, Aug 13, 9:43 AM

	Unknown Object (File)
	Wed, Aug 12, 9:12 AM

	Unknown Object (File)
	Wed, Aug 12, 9:04 AM

	Unknown Object (File)
	Wed, Aug 12, 5:07 AM

	Unknown Object (File)
	Tue, Aug 11, 1:19 PM

	Unknown Object (File)
	Sat, Aug 8, 4:10 PM

View All 82 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGeca9d8e7fa08: ifconfig: 802.11: factor out keyix printing
rG164bf9ffbe1a: ifconfig: 802.11: factor out keyix printing

Summary

The node unicast key (PTK) uses a key index of (-1) and printing
a 64k number does not look great. Factor out printing the key
number into a buffer and use 'ucast' for the node unicast key.
Hope is that this will be useful for the future as well when we
will have more/different keys possibly.

Looks like (with -vk):

AES-CCM 2:128-bit <xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> rsc 0 tsc 0 rx
AES-CCM 3:128-bit <xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> rsc 0 tsc 0 rx
AES-GCM ucast:128-bit <xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> rsc 0 tsc 0 tx+rx

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64476
Build 61360: arc lint + arc unit

Event Timeline

bz created this revision.May 27 2025, 8:02 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2025, 8:02 PM

bz requested review of this revision.May 27 2025, 8:02 PM

Harbormaster completed remote builds in B64476: Diff 156121.May 27 2025, 8:02 PM

bz added parent revisions: D50554: ifconfig: 802.11: print node unicast key (PTK) if available in STA mode, D50553: ifconfig: 802.11: also print IEEE80211_CIPHER_AES_GCM_128 information, D50552: ifconfig: 802.11: fix a warning message.May 27 2025, 8:02 PM

bz removed parent revisions: D50552: ifconfig: 802.11: fix a warning message, D50553: ifconfig: 802.11: also print IEEE80211_CIPHER_AES_GCM_128 information.

technically (cry) ucast will eventually be keyix 0 and keyix 1, but not the WEP/global slots. Aiee. :-)

-adrian

In D50555#1154134, @adrian wrote:

technically (cry) ucast will eventually be keyix 0 and keyix 1, but not the WEP/global slots. Aiee. :-)

I don't want to confuse people with ext key support just yet.

I just needed to print the current state somehow as it helps for debugging.
We can name it differently if you want...

adrian accepted this revision.Jun 7 2025, 2:43 PM

This revision is now accepted and ready to land.Jun 7 2025, 2:43 PM

Closed by commit rG164bf9ffbe1a: ifconfig: 802.11: factor out keyix printing (authored by bz). · Explain WhyJun 9 2025, 9:45 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG164bf9ffbe1a: ifconfig: 802.11: factor out keyix printing.

bz added a commit: rGeca9d8e7fa08: ifconfig: 802.11: factor out keyix printing.Jun 11 2025, 9:17 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

31 lines

Diff 156121

sbin/ifconfig/ifieee80211.c

Loading...