Differential D50468

share: Delete bitrotted make_*_driver.sh scripts
ClosedPublic
Actions

Authored by jrtc27 on May 22 2025, 4:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 14, 2:26 AM

	Unknown Object (File)
	Wed, Nov 12, 8:26 PM

	Unknown Object (File)
	Sat, Nov 8, 4:23 AM

	Unknown Object (File)
	Thu, Oct 30, 11:56 PM

	Unknown Object (File)
	Oct 25 2025, 10:07 AM

	Unknown Object (File)
	Oct 24 2025, 9:44 AM

	Unknown Object (File)
	Oct 16 2025, 11:46 PM

	Unknown Object (File)
	Oct 14 2025, 3:00 PM

View All 55 Files

Subscribers

Details

Reviewers

adrian
cperciva
imp
emaste

Commits

rG8f0a6a9aadb1: share: Delete bitrotted make_*_driver.sh scripts

Summary

These scripts have not seen the necessary changes to keep them up to
date with current KPIs and coding practices. They use I/O ports directly
rather than any bus abstractions, use i386 (which is on the way out for
kernel configs) as the architecture of choice for generated kernel
configs, use ISA KPIs, use INTR_TYPE_FAST (renamed in 2000 to INTR_FAST
and removed in 2011), and likely have other issues too that render them
more harm than good for the uninitiated developer looking for a driver
template. If anyone wants to invest time in modernising them they can do
so and bring them back, but for now delete them.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64359
Build 61243: arc lint + arc unit

Event Timeline

jrtc27 requested review of this revision.May 22 2025, 4:53 PM

jrtc27 created this revision.

Harbormaster completed remote builds in B64358: Diff 155873.May 22 2025, 4:53 PM

cperciva accepted this revision.May 22 2025, 4:55 PM

This revision is now accepted and ready to land.May 22 2025, 4:55 PM

Need ObsoleteFiles.inc update as well

This revision now requires changes to proceed.May 22 2025, 5:01 PM

Oh right yes these are actually-installed files (even more ugh), not something in tools/, so need to be unhooked from the build too. One moment...

Unhook from build and clean up

Harbormaster completed remote builds in B64359: Diff 155874.May 22 2025, 5:09 PM

emaste accepted this revision.May 22 2025, 5:19 PM

This revision is now accepted and ready to land.May 22 2025, 5:19 PM

yea, this is at least 15 years bit-rotted at this point

Closed by commit rG8f0a6a9aadb1: share: Delete bitrotted make_*_driver.sh scripts (authored by jrtc27). · Explain WhyJul 14 2025, 12:31 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG8f0a6a9aadb1: share: Delete bitrotted make_*_driver.sh scripts.

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

6 lines

share/

examples/

7 lines

drivers/

make_device_driver.sh

make_pseudo_driver.sh

tools/

build/

mk/

OptionalObsoleteFiles.inc

4 lines

Diff 155874

ObsoleteFiles.inc

Loading...

share/examples/Makefile

Loading...

share/examples/drivers/README

Loading...

share/examples/drivers/make_device_driver.sh

Loading...

share/examples/drivers/make_pseudo_driver.sh

Loading...

tools/build/mk/OptionalObsoleteFiles.inc

Loading...