libusb: add SUPER_PLUS in speed enum.
ClosedPublic
Actions

Authored by aokblast on Thu, May 15, 10:34 AM.

Details

Reviewers

bapt

Commits

rGf938c0a90313: libusb: add SUPER_PLUS in speed enum.

Summary

Some application(like usbmuxd) start to use LIBUSB_SPEED_SUPER_PLUS now.
Though we don't have the corresponding infra in kernel right now, it is
harmless to have this enum to prevent the compile error

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64202
Build 61086: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, May 15, 10:34 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, May 15, 10:34 AM

aokblast requested review of this revision.Thu, May 15, 10:34 AM

Harbormaster completed remote builds in B64196: Diff 155501.Thu, May 15, 10:34 AM

aokblast added a reviewer: bapt.Thu, May 15, 10:34 AM

aokblast added a subscriber: lwhsu.

bapt accepted this revision.Thu, May 15, 12:04 PM

This revision is now accepted and ready to land.Thu, May 15, 12:04 PM

lwhsu added inline comments.Thu, May 15, 2:53 PM

lib/libusb/libusb20.3
861	Don't forget also updating `.Dd` field. 😆 Also I'm not sure if we need/want mention that we don't have the corresponding infra in kernel in the caveat section.

Modify date

This revision now requires review to proceed.Thu, May 15, 5:05 PM

Harbormaster completed remote builds in B64202: Diff 155523.Thu, May 15, 5:05 PM

For someone who want to merge this patch, Thanks! https://github.com/aokblast/freebsd-src/commit/e1b577a32e31077549f192fa01543400329fefaa

lib/libusb/libusb20.3
861	I don't add anything to kernel. In kernel, it should use USB_SPEED_SUPER_PLUS which is the different enum from libusb one (with LIBUSB_SPEED in prefix). So I am not sure if we should add some warning on something nonexist.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 15, 6:31 PM

Closed by commit rGf938c0a90313: libusb: add SUPER_PLUS in speed enum. (authored by aokblast, committed by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rGf938c0a90313: libusb: add SUPER_PLUS in speed enum..

lwhsu added inline comments.Thu, May 15, 6:56 PM

lib/libusb/libusb20.3
861	it's exactly because we don't have it supported in kernel, while having that in the interface and document so we may need to warn people that it doesn't take actual effect.