Page MenuHomeFreeBSD

build.7: Document pkgbase PKG_FORMAT variable
ClosedPublic

Authored by ziaee on Mon, May 12, 8:55 PM.
Tags
None
Referenced Files
F117918121: D50318.id155357.diff
Sat, May 24, 12:55 PM
F117899554: D50318.id155454.diff
Sat, May 24, 10:50 AM
F117883414: D50318.id155358.diff
Sat, May 24, 6:16 AM
F117882671: D50318.diff
Sat, May 24, 6:04 AM
F117870892: D50318.id155453.diff
Sat, May 24, 2:41 AM
F117868125: D50318.id.diff
Sat, May 24, 2:02 AM
F117867519: D50318.id155361.diff
Sat, May 24, 1:52 AM
Unknown Object (File)
Fri, May 23, 4:56 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64176
Build 61060: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Mon, May 12, 8:55 PM
share/man/man7/build.7
659–662

Maybe just refer the reader to the list for formats in pkg-create(8)?

666

Default changed in 820fbcf25bb2c

ziaee marked an inline comment as done.

Update default compression format.

share/man/man7/build.7
659–662

Maybe just refer the reader to the list for formats in pkg-create(8)?

I'm torn, the pros and cons of this are both strong. Eliminating documentation proliferation improves documentation quality by easing maintenance, but having to go read a choose your own adventure novel of doc to do something is a tedious UX.

666

Awesome, thank you.

share/man/man7/build.7
659–662

IMO there are two sensible options for PKG_FORMAT -- leave it at the default (tzst) or set it to tar if you want uncompressed packages.

share/man/man7/build.7
659–662

That makes perfect sense, but I'm hesitant to write a recommendation instead where we'd usually usually list supported options in the wide body of manuals. The manual subsystem consistently reinforces people to consult the manual to see supported options.

We have a good consistency for a long time of:

Introductory sentence explaining what it is. Supported options. Default.

And people seem to like that when it's there.

share/man/man7/build.7
659–662

NACK. Duplicated information/lists are liable to become stale, and this is a common problem in our docs. What link exists such that someone updating pkg-create(8) would know to update this piece of documentation as well?

What should be communicated here is:

  • The basic meaning of the variable in English
  • A link to the supported formats (the source of truth)
  • The default value (which is decided/enforced by the build itself)

I should have been clearer that I was not objecting to changing this,
just unsure for the reasons listed.

I'm fine with this version.

This revision is now accepted and ready to land.Wed, May 14, 3:38 PM

Added tar, switched Dv to Ql for clarity.

This revision now requires review to proceed.Wed, May 14, 3:42 PM
This revision is now accepted and ready to land.Wed, May 14, 3:42 PM
This revision was automatically updated to reflect the committed changes.