There is no longer a sorted page list maintained by a vm_object, so there is no longer a need for the mpred parameter to vm_page_insert_lookup(). Dropping that parameter creates new functions that also don't need that parameter. Drop all those parameters. Some of the functions have names ending in "_after", where "after" refers to the mpred parameter that is being dropped. So that those names make sense, change "_after" to "_iter" in all of them, because they all take pctrie_iter parameters. Make those parameters last in parameter lists, as "mpred" was before.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/vm/vm_page.c | ||
|---|---|---|
| 1475 | There is no lookup parameter anymore. | |
| 1559–1561 | This is really a "fix" to the memq removal, and could be committed separately. | |
| 1960–1963 | At the very least, the first sentence is still true. Why is it be removed? | |
| sys/vm/vm_page.h | ||
| 81–84 | This is really a "fix" to the memq removal, and could be committed separately. | |
| 610–614 | This is no longer sorted. | |
| 644 | ||
| sys/vm/vm_page.c | ||
|---|---|---|
| 1559–1561 | Okay, I'll restore the comment, so that it can be removed separately later. | |
| 1960–1963 | I'll restore the first sentence. There is no listq iterator anymore. | |
| sys/vm/vm_page.h | ||
| 81–84 | Okay, I'll restore the comment. | |
| 610–614 | This is already not sorted. I can sort these in a separate commit before, or after this, or as part of this. | |