umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform
ClosedPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Details

Reviewers

chs
ken
markj
mav

Commits

rG86de66a67432: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform

Summary

Only doing a short inquiry and converting TUR to START STOP UNIT are the
same everywhere, so move those quirks to umass_std_transform.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63902
Build 60786: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63079: Diff 152571.Mar 23 2025, 9:50 PM

imp added a parent revision: D49471: umass: Move common code into umass_std_transform.Mar 23 2025, 9:50 PM

imp added a child revision: D49473: umass: Be more consistent about how we fail bad commands.

Note: I think TUR quirk is bogus, but don't have the courage to remove it.

imp added reviewers: chs, ken, markj, mav.Apr 2 2025, 8:05 PM

rebase

Harbormaster completed remote builds in B63902: Diff 154869.May 5 2025, 4:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:37 PM

Closed by commit rG86de66a67432: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG86de66a67432: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

100 lines

Diff 154869

View Options

sys/dev/usb/storage/umass.c

umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transformClosedPublicActions