umass: Move common code into umass_std_transform
ClosedPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Details

Reviewers

mav
markj
ken
chs

Commits

rGb8e77c8b00c1: umass: Move common code into umass_std_transform

Summary

Move the length checks, and byte copying into umass_std_transform. The
copies are typically small and this simplifies the code a lot. Move
zeroing the buffer now to only when we change TEST UNIT READY to START
STOP.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63078: Diff 152570.Mar 23 2025, 9:50 PM

imp added a parent revision: D49470: umass: make *_transform() return a bool.Mar 23 2025, 9:50 PM

imp added a child revision: D49472: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform.

imp added reviewers: mav, nakayamakenjiro_gmail.com, markj.Mar 24 2025, 1:03 AM

LGTM, but could it be that I was assigned by mistake? I haven't submitted any patches around this part of the code.

In D49471#1128464, @nakayamakenjiro_gmail.com wrote:

LGTM, but could it be that I was assigned by mistake? I haven't submitted any patches around this part of the code.

Ah yes. It was by mistake, but thanks for the eyeballs and your time.

imp added a reviewer: chs.Apr 2 2025, 8:05 PM

rebase

Harbormaster completed remote builds in B63901: Diff 154868.May 5 2025, 4:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:37 PM

Closed by commit rGb8e77c8b00c1: umass: Move common code into umass_std_transform (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGb8e77c8b00c1: umass: Move common code into umass_std_transform.