Add a shutdown precaution measure
ClosedPublic
Actions

Authored by kib on May 5 2025, 10:23 AM.

Details

Reviewers

bapt
kevans
imp
olce

Commits

rG384d976725a5: rc.d: Add precious_machine rc.conf knob to create /var/run/noshutdown
rG7fb88c20eccc: shutdown(8): refuse to run if /var/run/noshutdown is present
rG5ab906195b35: include/paths.h: add _PATH_NOSHUTDOWN

Summary

After I rebooted the unintended machine N times due to typing poweroff in the wrong ssh session, I think it is worth to add some optional safety belts there, at least for me.

By default, nothing changes. If 'precious_machine' is set to true in rc.conf, the /var/run/noshutdown file is created on boot.

shutdown(8) refuses to do any changes to the system state if the file is present. User must manually remove it to get shutdown going.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.May 5 2025, 10:23 AM

Herald added a subscriber: ziaee. · View Herald TranscriptMay 5 2025, 10:23 AM

kib requested review of this revision.May 5 2025, 10:23 AM

Herald added a subscriber: cy. · View Herald TranscriptMay 5 2025, 10:23 AM

This seems reasonable. I don't see how to implement this in a simpler fashion.

libexec/rc/rc.d/noshutdown
7	Since that touches things in `/var/run` (and `var` depends on `mountcritremote`). What is the reason of requiring `syslogd` here ?
sbin/shutdown/shutdown.8
243

I love this, I am wondering if -i is the right option, the natural option I would have been looking for is -f for force, rather that -i for ignore, I don't think it is a big deal, and I am fine with -i

kib marked 2 inline comments as done.May 5 2025, 11:03 AM

kib added inline comments.