Paths

Table of Contentst

Differential D49975

queue(3): Add simple tests for some macros for all list/tailq types
ClosedPublic
Actions

Authored by olce on Apr 23 2025, 10:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 5, 3:49 PM

	Unknown Object (File)
	Sun, Aug 3, 7:16 AM

	Unknown Object (File)
	Sun, Jul 27, 2:55 PM

	Unknown Object (File)
	Sun, Jul 27, 1:20 AM

	Unknown Object (File)
	Jul 8 2025, 4:55 PM

	Unknown Object (File)
	Jul 7 2025, 9:31 AM

	Unknown Object (File)
	Jun 26 2025, 6:29 AM

	Unknown Object (File)
	Jun 25 2025, 8:13 PM

View All 45 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rG482647102642: queue(3): Add simple tests for some macros for all list/tailq types
rG4fa275a5f357: queue(3): Add simple tests for some macros for all list/tailq types

Summary

These essentially test building a list/tailq of 100 elements with
_INSERT_HEAD(), iterating over them with _FOREACH(), splitting it with
_SPLIT_AFTER() and concatenating back the results with _CONCAT(),
checking that the lists/tailqs at each step have the right number of
elements and at the expected positions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63754
Build 60638: arc lint + arc unit

Event Timeline

olce created this revision.Apr 23 2025, 10:05 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 23 2025, 10:05 AM

olce requested review of this revision.Apr 23 2025, 10:05 AM

Harbormaster completed remote builds in B63662: Diff 154153.Apr 23 2025, 10:05 AM

olce added a parent revision: D49974: queue(3): Wrap all QMD_PANIC() guards with __predict_false().Apr 23 2025, 10:19 AM

Define QUEUE_MACRO_DEBUG_ASSERTIONS explicitly (as this is not automatically enabled for userland programs).

Harbormaster completed remote builds in B63675: Diff 154167.Apr 23 2025, 1:20 PM

markj added inline comments.Apr 23 2025, 9:08 PM

tests/sys/sys/queue_test.c
4	This file is missing a license header. Why is cdefs.h needed?

olce marked an inline comment as done.Apr 28 2025, 10:06 AM

olce added inline comments.

tests/sys/sys/queue_test.c
4	Why is cdefs.h needed? It doesn't seem so, removed. Probably a leftover from an earlier version that needed it.

Add license header.
Remove include of <cdefs.h>.

Harbormaster completed remote builds in B63754: Diff 154402.Apr 28 2025, 12:51 PM

unsigned => u_int
Fix a typo in a comment

Harbormaster completed remote builds in B63757: Diff 154416.Apr 28 2025, 7:14 PM

Thanks for adding these.

This revision is now accepted and ready to land.Apr 29 2025, 1:10 AM

Closed by commit rG4fa275a5f357: queue(3): Add simple tests for some macros for all list/tailq types (authored by olce). · Explain WhyApr 29 2025, 7:47 AM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG4fa275a5f357: queue(3): Add simple tests for some macros for all list/tailq types.

olce added a commit: rG482647102642: queue(3): Add simple tests for some macros for all list/tailq types.May 1 2025, 7:55 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

sys/

1 line

235 lines

Diff 154402

tests/sys/sys/Makefile

Loading...

tests/sys/sys/queue_test.c

Loading...