Paths

Table of Contentst

Differential D49974

queue(3): Wrap all QMD_PANIC() guards with __predict_false()
ClosedPublic
Actions

Authored by olce on Apr 23 2025, 10:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 1, 7:22 PM

	Unknown Object (File)
	Fri, Jun 27, 2:19 AM

	Unknown Object (File)
	Wed, Jun 25, 9:35 AM

	Unknown Object (File)
	Tue, Jun 24, 12:06 AM

	Unknown Object (File)
	Mon, Jun 23, 7:48 AM

	Unknown Object (File)
	Sat, Jun 21, 10:43 PM

	Unknown Object (File)
	Fri, Jun 20, 9:04 AM

	Unknown Object (File)
	Thu, Jun 19, 6:17 PM

View All 24 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rG542e14a59bca: queue(3): Wrap QMD_ASSERT()'s guard with __predict_false()
rG613d66b5e17d: queue(3): Wrap QMD_ASSERT()'s guard with __predict_false()

Summary

All these guards are bound to be almost always false (obviously).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Apr 23 2025, 10:05 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 23 2025, 10:05 AM

olce requested review of this revision.Apr 23 2025, 10:05 AM

Harbormaster completed remote builds in B63661: Diff 154152.Apr 23 2025, 10:05 AM

olce added a parent revision: D49973: queue(3): Debug macros: Finer control knobs, userland support.Apr 23 2025, 10:19 AM

olce added a child revision: D49975: queue(3): Add simple tests for some macros for all list/tailq types.

I imagine the compiler might infer this already but I don't think it hurts readability in any significant way, so sure.

This revision is now accepted and ready to land.Apr 23 2025, 12:23 PM

In D49974#1139786, @emaste wrote:

I imagine the compiler might infer this already but I don't think it hurts readability in any significant way, so sure.

It could (for the regular panic() case, and more generally "noreturn" functions), although there might be cases where the "noreturn" path is actually the most probable, but this is arguably niche and could understandably be ignored by the compiler. Cases where one does not want to actually panic, but just print a diagnostic message and continue, would benefit from this but are likely edge cases. I was not too sure about doing this change, but as you say it doesn't hurt either.

Closed by commit rG613d66b5e17d: queue(3): Wrap QMD_ASSERT()'s guard with __predict_false() (authored by olce). · Explain WhyApr 28 2025, 12:24 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG613d66b5e17d: queue(3): Wrap QMD_ASSERT()'s guard with __predict_false().

olce added a commit: rG542e14a59bca: queue(3): Wrap QMD_ASSERT()'s guard with __predict_false().May 1 2025, 7:55 PM

Revision Contents
Changeset List

Path

Size

sys/

sys/

2 lines

Diff 154400

sys/sys/queue.h

Loading...