Page MenuHomeFreeBSD

iwlwifi.4: Update modes for recent 802.11ac
ClosedPublic

Authored by ziaee on Apr 21 2025, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 18, 4:04 PM
Unknown Object (File)
Wed, May 7, 6:24 AM
Unknown Object (File)
Tue, May 6, 9:14 AM
Unknown Object (File)
Tue, May 6, 6:54 AM
Unknown Object (File)
Sat, May 3, 8:25 AM
Unknown Object (File)
Apr 29 2025, 12:35 AM
Unknown Object (File)
Apr 28 2025, 4:38 PM
Unknown Object (File)
Apr 27 2025, 6:40 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63648
Build 60532: arc lint + arc unit

Event Timeline

bz requested changes to this revision.Apr 21 2025, 6:00 PM

If we want to stay more accurate.

We'll also need to add fwget(8) as in rtw88(4) but I'll open a separate review for this.
I need to update the man page from the script the next days hopefully anyway.

share/man/man4/iwlwifi.4
260

the compatibility code currently only supports 802.11a/b/g/n/ac modes (802.11n/ac only for the 22000 and later chipsets).

This revision now requires changes to proceed.Apr 21 2025, 6:00 PM

Do you think it's okay to use the style I used for firmware in the latest draft of iwx.4? I think the predictability of following the mdoc standard sections is a major strength of this type of documentation, and I think it's reasonable to put the snippet about firmware and fwget in FILES, so that really helps with the structure of the page.

This revision is now accepted and ready to land.Apr 23 2025, 11:53 PM
emaste added inline comments.
share/man/man4/iwlwifi.4
68–69

I'm not really sure it's right to claim iwx supports "older" chipsets - iwx is a driver providing complementary support for some of the same devices supported by this driver.

262–263

We ought to combine these statements -- .11ax, .11be, 6GHz are all to come.

bz requested changes to this revision.Apr 24 2025, 12:18 AM

Pressing equest changes for @emaste

share/man/man4/iwlwifi.4
68–69

Then we should rephrase the entire bit as the same goes for iwm. Or just say "support a selection of chipsets" or something like that?

From an iwlwifi point of view iwx is an older driver (dvm == ~iwn, mvm == ~iwm/iwx, mld == no equivalent). Loking at 6.15-rc the MLD bits from the BE200 and later (11be chipsets and later) are split out now. We've supported them since 14.1(?) when they part of mvm still. OpenBSD can write their next driver copy now. And we can likely just add "bn" as well to the list by the end of the year and be good.

This revision now requires changes to proceed.Apr 24 2025, 12:18 AM

Fix glaring omission in CAVEATS, thanks @emaste!
Revert attempt to mention iwx, I'm starting to understand out of scope.

Commit LGTM, if someone confirms the factual accuracy.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2025, 4:26 PM
This revision was automatically updated to reflect the committed changes.