Page MenuHomeFreeBSD
Differential D49959

wpa_supplicant: Handle systems without INET (legacy IP) support
ClosedPublic
Actions

Authored by zarychtam_plan-b.pwste.edu.pl on Tue, Apr 22, 1:39 PM.
Tags
None
Referenced Files
F115742502: D49959.diff
Mon, Apr 28, 12:15 AM
F115741387: D49959.diff
Sun, Apr 27, 11:53 PM
Unknown Object (File)
Sun, Apr 27, 2:10 AM
Unknown Object (File)
Sat, Apr 26, 6:53 AM
Unknown Object (File)
Wed, Apr 23, 8:48 AM
Unknown Object (File)
Wed, Apr 23, 8:48 AM
Unknown Object (File)
Wed, Apr 23, 8:47 AM
Unknown Object (File)
Wed, Apr 23, 8:44 AM
View All 13 Files
Subscribers
imp
roy_marples.name

Details

Reviewers
cy
bz
adrian
philip
roy_marples.name
Group Reviewers
network
Commits
rG8c7149c73f8f: wpa_supplicant: Handle systems without INET (legacy IP) support
Summary

Currently, wpa_supplicant fails when legacy IP support is disabled in FreeBSD (i.e., the world built with WITHOUT_INET and nooptions INET in the kernel config). The proposed patch allows running wpa_supplicant and connecting to wireless networks without INET support when INET6 is available.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zarychtam_plan-b.pwste.edu.pl requested review of this revision.Tue, Apr 22, 1:39 PM
zarychtam_plan-b.pwste.edu.pl created this revision.
adrian accepted this revision.Tue, Apr 22, 3:35 PM

I think this is fine for now. Ouch. ;-)

This revision is now accepted and ready to land.Tue, Apr 22, 3:35 PM
zarychtam_plan-b.pwste.edu.pl added a reviewer: roy_marples.name.Tue, Apr 22, 7:28 PM
zarychtam_plan-b.pwste.edu.pl added a subscriber: roy_marples.name.

Thank you for the support @adrian.
I am adding @roy_marples.name as a reviewer, he has deep insight since contributed a lot to this project.
The patch was submitted to the upstream and is awaiting acceptance.

roy_marples.name accepted this revision.EditedTue, Apr 22, 7:45 PM

LGTM.

Tested on NetBSD-10 just by changing PF_INET TO PF_INET6 and it works just as before.

bz requested changes to this revision.Tue, Apr 22, 7:49 PM
bz added inline comments.
contrib/wpa/src/drivers/driver_bsd.c
1803

Why EPROTONOSUPPORT? SOCK_DRAM being a problem you'd have to try SOCK_STREAM?

1804

Indentation looks wrong for the inside of this block.

This revision now requires changes to proceed.Tue, Apr 22, 7:49 PM
zarychtam_plan-b.pwste.edu.pl updated this revision to Diff 154124.Tue, Apr 22, 9:00 PM

Improved readability (indentations adjusted), unused condition removed.

zarychtam_plan-b.pwste.edu.pl marked 2 inline comments as done.Tue, Apr 22, 9:00 PM
philip accepted this revision as: philip.Wed, Apr 23, 6:31 AM

Looks good to me. Thank you for addressing @bz's comments.

cy accepted this revision as: cy.Fri, Apr 25, 2:11 AM

LGTM following bz@'s suggestion.

cy accepted this revision.Mon, Apr 28, 12:04 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Apr 28, 12:05 AM
Closed by commit rG8c7149c73f8f: wpa_supplicant: Handle systems without INET (legacy IP) support (authored by zarychtam_plan-b.pwste.edu.pl, committed by cy). · Explain Why
This revision was automatically updated to reflect the committed changes.
cy added a commit: rG8c7149c73f8f: wpa_supplicant: Handle systems without INET (legacy IP) support.
Herald added a subscriber: imp. · View Herald TranscriptMon, Apr 28, 12:05 AM
cy mentioned this in D50050: wpa_supplicant: Use PF_LOCAL instead of PF_INET*.Mon, Apr 28, 2:03 AM

Revision Contents
Changeset List

PathSize
contrib/
wpa/
src/
drivers/
10 lines

Diff 154124

View Options

contrib/wpa/src/drivers/driver_bsd.c

Loading...