Page MenuHomeFreeBSD
Differential D49927

powerpc: replace tailq pointers with iterators
ClosedPublic
Actions

Authored by dougm on Apr 20 2025, 5:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 13, 2:36 AM
Unknown Object (File)
Sat, Aug 9, 2:43 PM
Unknown Object (File)
Mon, Aug 4, 12:45 PM
Unknown Object (File)
Sat, Aug 2, 4:21 PM
Unknown Object (File)
Sat, Aug 2, 11:39 AM
Unknown Object (File)
Sat, Aug 2, 12:03 AM
Unknown Object (File)
Jul 23 2025, 11:48 AM
Unknown Object (File)
Jul 7 2025, 2:25 AM
View All 38 Files
Subscribers
imp
jhibbits

Details

Reviewers
kib
markj
Commits
rGb6cd84ca2d08: powerpc: replace tailq pointers with iterators
Summary

Change architecture-specific code to use iterators rather than tailq pointers.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Apr 20 2025, 5:50 AM
Herald added a subscriber: jhibbits. · View Herald TranscriptApr 20 2025, 5:50 AM
dougm requested review of this revision.Apr 20 2025, 5:50 AM
kib added inline comments.Apr 20 2025, 12:44 PM
sys/powerpc/aim/mmu_oea64.c
3800

I am curious why this condition is needed now.

dougm added inline comments.Apr 20 2025, 5:22 PM
sys/powerpc/aim/mmu_oea64.c
3800

make buildkernel TARGET=powerpc TARGET_ARCH=powerpc will emit these lines:

--- mmu_oea64.o ---
/freebsd/dougm/src/sys/powerpc/aim/mmu_oea64.c:3804:1: warning: unused function 'moea64_sp_promote' [-Wunused-function]
 3804 | moea64_sp_promote(pmap_t pmap, vm_offset_t va, vm_page_t m)
      | ^~~~~~~~~~~~~~~~~

If the condition is removed.

kib accepted this revision.Apr 20 2025, 6:32 PM
kib added inline comments.
sys/powerpc/aim/mmu_oea64.c
3800

Ok, it is fine, but should be a separate commit.

This revision is now accepted and ready to land.Apr 20 2025, 6:32 PM
dougm updated this revision to Diff 153986.Apr 20 2025, 8:47 PM

Add braces. Drop a null check. Restore a physical address check. Drop attempts to silence compiler warnings.

This revision now requires review to proceed.Apr 20 2025, 8:47 PM
kib accepted this revision.Apr 20 2025, 11:26 PM
This revision is now accepted and ready to land.Apr 20 2025, 11:26 PM
Closed by commit rGb6cd84ca2d08: powerpc: replace tailq pointers with iterators (authored by dougm). · Explain WhyApr 21 2025, 4:13 AM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGb6cd84ca2d08: powerpc: replace tailq pointers with iterators.
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2025, 4:13 AM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
aim/
16 lines
17 lines
31 lines
booke/
15 lines

Diff 153986

View Options

sys/powerpc/aim/mmu_oea.c

Loading...
View Options

sys/powerpc/aim/mmu_oea64.c

Loading...
View Options

sys/powerpc/aim/mmu_radix.c

Loading...
View Options

sys/powerpc/booke/pmap.c

Loading...