Page MenuHomeFreeBSD
Differential D49927

powerpc: replace tailq pointers with iterators
ClosedPublic
Actions

Authored by dougm on Apr 20 2025, 5:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 14, 1:03 PM
Unknown Object (File)
Apr 25 2025, 7:57 PM
Unknown Object (File)
Apr 25 2025, 1:03 PM
Unknown Object (File)
Apr 25 2025, 9:52 AM
Unknown Object (File)
Apr 25 2025, 6:32 AM
Unknown Object (File)
Apr 25 2025, 4:33 AM
Unknown Object (File)
Apr 23 2025, 6:48 AM
Unknown Object (File)
Apr 22 2025, 5:02 AM
View All 15 Files
Subscribers
imp
jhibbits

Details

Reviewers
kib
markj
Commits
rGb6cd84ca2d08: powerpc: replace tailq pointers with iterators
Summary

Change architecture-specific code to use iterators rather than tailq pointers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.Apr 20 2025, 5:50 AM
Herald added a subscriber: jhibbits. · View Herald TranscriptApr 20 2025, 5:50 AM
dougm requested review of this revision.Apr 20 2025, 5:50 AM
kib added inline comments.Apr 20 2025, 12:44 PM
sys/powerpc/aim/mmu_oea64.c
3802

I am curious why this condition is needed now.

dougm added inline comments.Apr 20 2025, 5:22 PM
sys/powerpc/aim/mmu_oea64.c
3802

make buildkernel TARGET=powerpc TARGET_ARCH=powerpc will emit these lines:

--- mmu_oea64.o ---
/freebsd/dougm/src/sys/powerpc/aim/mmu_oea64.c:3804:1: warning: unused function 'moea64_sp_promote' [-Wunused-function]
 3804 | moea64_sp_promote(pmap_t pmap, vm_offset_t va, vm_page_t m)
      | ^~~~~~~~~~~~~~~~~

If the condition is removed.

kib accepted this revision.Apr 20 2025, 6:32 PM
kib added inline comments.
sys/powerpc/aim/mmu_oea64.c
3802

Ok, it is fine, but should be a separate commit.

This revision is now accepted and ready to land.Apr 20 2025, 6:32 PM
dougm updated this revision to Diff 153986.Apr 20 2025, 8:47 PM

Add braces. Drop a null check. Restore a physical address check. Drop attempts to silence compiler warnings.

This revision now requires review to proceed.Apr 20 2025, 8:47 PM
kib accepted this revision.Apr 20 2025, 11:26 PM
This revision is now accepted and ready to land.Apr 20 2025, 11:26 PM
Closed by commit rGb6cd84ca2d08: powerpc: replace tailq pointers with iterators (authored by dougm). · Explain WhyApr 21 2025, 4:13 AM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGb6cd84ca2d08: powerpc: replace tailq pointers with iterators.
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2025, 4:13 AM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
aim/
16 lines
17 lines
31 lines
booke/
15 lines

Diff 154013

View Options

sys/powerpc/aim/mmu_oea.c

Loading...
View Options

sys/powerpc/aim/mmu_oea64.c

Loading...
View Options

sys/powerpc/aim/mmu_radix.c

Loading...
View Options

sys/powerpc/booke/pmap.c

Loading...