Page MenuHomeFreeBSD

powerpc: replace tailq pointers with iterators
ClosedPublic

Authored by dougm on Apr 20 2025, 5:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 24, 7:31 PM
Unknown Object (File)
Mon, Nov 24, 7:31 PM
Unknown Object (File)
Mon, Nov 24, 7:31 PM
Unknown Object (File)
Mon, Nov 24, 7:31 PM
Unknown Object (File)
Mon, Nov 24, 7:30 PM
Unknown Object (File)
Thu, Nov 20, 2:25 AM
Unknown Object (File)
Fri, Nov 14, 8:24 AM
Unknown Object (File)
Wed, Nov 12, 8:41 AM
Subscribers

Details

Summary

Change architecture-specific code to use iterators rather than tailq pointers.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Apr 20 2025, 5:50 AM
sys/powerpc/aim/mmu_oea64.c
3802

I am curious why this condition is needed now.

sys/powerpc/aim/mmu_oea64.c
3802

make buildkernel TARGET=powerpc TARGET_ARCH=powerpc will emit these lines:

--- mmu_oea64.o ---
/freebsd/dougm/src/sys/powerpc/aim/mmu_oea64.c:3804:1: warning: unused function 'moea64_sp_promote' [-Wunused-function]
 3804 | moea64_sp_promote(pmap_t pmap, vm_offset_t va, vm_page_t m)
      | ^~~~~~~~~~~~~~~~~

If the condition is removed.

kib added inline comments.
sys/powerpc/aim/mmu_oea64.c
3802

Ok, it is fine, but should be a separate commit.

This revision is now accepted and ready to land.Apr 20 2025, 6:32 PM

Add braces. Drop a null check. Restore a physical address check. Drop attempts to silence compiler warnings.

This revision now requires review to proceed.Apr 20 2025, 8:47 PM
This revision is now accepted and ready to land.Apr 20 2025, 11:26 PM
This revision was automatically updated to reflect the committed changes.