Differential D49886

Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG
ClosedPublic
Actions

Authored by dim on Apr 18 2025, 10:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 2, 11:14 PM

	Unknown Object (File)
	Sat, Aug 2, 4:46 AM

	Unknown Object (File)
	Sat, Jul 26, 5:07 AM

	Unknown Object (File)
	Fri, Jul 25, 9:58 AM

	Unknown Object (File)
	Fri, Jul 25, 6:32 AM

	Unknown Object (File)
	Thu, Jul 24, 5:22 PM

	Unknown Object (File)
	Wed, Jul 23, 4:30 PM

	Unknown Object (File)
	Jul 9 2025, 7:53 AM

View All 44 Files

Subscribers

guest-patmaddox

Details

Reviewers

emaste
avg
jhb
imp

Commits

rG5195ff613fca: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG
rG3f68c3e9c138: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG
rGea231471d024: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG

Summary

When WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG are both set, the
cross-tools stage does not build a cross clang binary. This is because
the Makefile in usr.bin/clang checks for WITHOUT_CLANG, and skips
building the binary.

To fix this, ensure that WITH_CLANG is set for the cross-tools phase
whenever WITH_CLANG_BOOTSTRAP is set. While here, skip using the
Makefile in usr.bin/clang, and directly use the Makefile in
usr.bin/clang/clang instead.

Reported by: avg
PR: 286154
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim requested review of this revision.Apr 18 2025, 10:56 AM

dim created this revision.

Harbormaster completed remote builds in B63575: Diff 153826.Apr 18 2025, 10:56 AM

LGTM.

Thank you!

This revision is now accepted and ready to land.Apr 18 2025, 1:32 PM

emaste accepted this revision.Apr 18 2025, 1:56 PM

Closed by commit rGea231471d024: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG (authored by dim). · Explain WhyApr 18 2025, 6:33 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rGea231471d024: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG.

guest-patmaddox added a subscriber: guest-patmaddox.Apr 18 2025, 9:57 PM

dim added a commit: rG3f68c3e9c138: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG.Apr 23 2025, 7:38 PM

dim added a commit: rG5195ff613fca: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG.

Revision Contents
Changeset List

Path

Size

3 lines

Diff 153880

Makefile.inc1

Loading...