Page MenuHomeFreeBSD
Differential D49821

release: Avoid sparse-file handling for container image layers
ClosedPublic
Actions

Authored by dfr on Apr 14 2025, 9:48 AM.
Tags
None
Referenced Files
F154364763: D49821.id153631.diff
Tue, Apr 28, 3:19 AM
F154306605: D49821.id153711.diff
Mon, Apr 27, 5:54 PM
F154278077: D49821.id153682.diff
Mon, Apr 27, 1:41 PM
F154222628: D49821.id153711.diff
Mon, Apr 27, 5:53 AM
Unknown Object (File)
Wed, Apr 22, 4:23 AM
Unknown Object (File)
Tue, Apr 21, 4:59 PM
Unknown Object (File)
Mon, Apr 13, 4:36 AM
Unknown Object (File)
Mon, Apr 13, 2:10 AM
View All 91 Files
Subscribers
imp
jlduran
jrtc27

Details

Reviewers
dch
cperciva
jfree
Commits
rG4317d0aa8c21: release: avoid sparse-file handling for container image layers
rG3a79ca65531a: release: avoid sparse-file handling for container image layers
Summary

This improves compatiblity with Podman. See
https://github.com/containers/podman/issues/25270 for details.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dfr created this revision.Apr 14 2025, 9:48 AM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptApr 14 2025, 9:48 AM
dfr requested review of this revision.Apr 14 2025, 9:48 AM
Harbormaster completed remote builds in B63495: Diff 153631.Apr 14 2025, 9:48 AM
jlduran added a subscriber: jlduran.Apr 14 2025, 1:14 PM

The GitHub issue should be:
https://github.com/containers/podman/issues/25270

dfr added a comment.Apr 14 2025, 1:24 PM
In D49821#1135863, @jlduran wrote:

The GitHub issue should be:
https://github.com/containers/podman/issues/25270

Good catch, thanks! I've fixed this in my local git repo.

dch accepted this revision.Apr 15 2025, 9:16 AM

LGTM, testing with stable/14 today. thanks Doug for tracking this down & explaining it.

release/scripts/make-oci-image.sh
102

s/incompatiblity/incompatibility/

This revision is now accepted and ready to land.Apr 15 2025, 9:16 AM
dfr updated this revision to Diff 153682.Apr 15 2025, 1:56 PM

This version disables sparse-file handling which is the cause of the incompatibility with Podman

This revision now requires review to proceed.Apr 15 2025, 1:56 PM
Harbormaster completed remote builds in B63518: Diff 153682.Apr 15 2025, 1:56 PM
dfr retitled this revision from release: use gtar for container image layers to release: Avoid sparse-file handling for container image layers.Apr 15 2025, 3:33 PM
dfr edited the summary of this revision. (Show Details)
dfr marked an inline comment as done.
dfr added a comment.Apr 15 2025, 4:45 PM
In D49821#1136169, @dch wrote:

LGTM, testing with stable/14 today. thanks Doug for tracking this down & explaining it.

Could you possibly test with the new version? This simply disables the use of sparse file handling in bsdtar and avoids the need to add a dependency on gnu tar.

dch added a comment.Apr 15 2025, 5:26 PM

thanks Doug, rebuilding with latest version atm.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2025, 10:02 PM
Closed by commit rG3a79ca65531a: release: avoid sparse-file handling for container image layers (authored by dfr, committed by dch). · Explain Why
This revision was automatically updated to reflect the committed changes.
dch added a commit: rG3a79ca65531a: release: avoid sparse-file handling for container image layers.
dch added a commit: rG4317d0aa8c21: release: avoid sparse-file handling for container image layers.Apr 15 2025, 10:11 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
9 lines

Diff 153711

View Options

release/scripts/make-oci-image.sh

Loading...