Page MenuHomeFreeBSD
Differential D49810

linuxkpi: Move `release_pages()` to linux_page.c
ClosedPublic
Actions

Authored by dumbbell on Apr 13 2025, 11:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 11:14 AM
Unknown Object (File)
Wed, Nov 5, 4:14 AM
Unknown Object (File)
Wed, Nov 5, 3:31 AM
Unknown Object (File)
Wed, Nov 5, 12:21 AM
Unknown Object (File)
Tue, Nov 4, 10:24 PM
Unknown Object (File)
Tue, Nov 4, 4:10 PM
Unknown Object (File)
Wed, Oct 29, 1:46 PM
Unknown Object (File)
Sun, Oct 26, 10:33 PM
View All 67 Files
Subscribers
emaste
imp
wulf

Details

Reviewers
markj
Group Reviewers
linuxkpi
Commits
rGe51729f608da: linuxkpi: Move `release_pages()` to linux_page.c
Summary

We want to avoid putting code managing memory in inline functions in the future.

This is part of the update of DRM drivers to Linux 6.7. This is a follow-up to D48743.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell created this revision.Apr 13 2025, 11:27 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptApr 13 2025, 11:27 AM
dumbbell requested review of this revision.Apr 13 2025, 11:27 AM
dumbbell added a reviewer: markj.
dumbbell mentioned this in D48743: linuxkpi: Add `folio` and `folio_batch` APIs.Apr 13 2025, 11:37 AM
wulf added a subscriber: wulf.Apr 13 2025, 2:47 PM
wulf added inline comments.
sys/compat/linuxkpi/common/src/linux_page.c
180

Please add lkpi_ or linuxkpi_ prefix with corresponding #define to not pollute namespace

dumbbell updated this revision to Diff 153652.Apr 14 2025, 6:56 PM

Rename release_pages() to linux_release_pages() to address @wulf concern.

dumbbell mentioned this in D49811: linuxkpi: Move `put_page()` closer to `get_page()`.Apr 14 2025, 6:58 PM
markj accepted this revision.Apr 15 2025, 1:38 PM
This revision is now accepted and ready to land.Apr 15 2025, 1:38 PM
dumbbell marked an inline comment as done.May 8 2025, 9:25 AM
Closed by commit rGe51729f608da: linuxkpi: Move `release_pages()` to linux_page.c (authored by dumbbell). · Explain WhyMay 12 2025, 5:47 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rGe51729f608da: linuxkpi: Move `release_pages()` to linux_page.c.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
3 lines
9 lines
src/
9 lines

Diff 153652

View Options

sys/compat/linuxkpi/common/include/linux/mm.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/pagemap.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_page.c

Loading...