Page MenuHomeFreeBSD
Differential D49723

USES= go: support v2 and higher proxy URLs
ClosedPublic
Actions

Authored by ngie on Apr 9 2025, 2:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 13, 6:00 AM
Unknown Object (File)
Sat, Sep 6, 4:00 AM
Unknown Object (File)
Sun, Aug 31, 12:56 AM
Unknown Object (File)
Tue, Aug 26, 5:53 PM
Unknown Object (File)
Aug 5 2025, 1:21 PM
Unknown Object (File)
Jul 25 2025, 8:43 AM
Unknown Object (File)
Jul 16 2025, 9:13 AM
Unknown Object (File)
Jul 13 2025, 1:52 AM
View All 30 Files
Subscribers
None

Details

Reviewers
adamw
rene
mat
arrowd
tijl
Commits
R11:0647dd427458: Mk/Uses/go.mk: support v2 and higher proxy URLs
Summary

golang projects with versions greater than 2.x have different URLs
presented for them via ${GOPROXY} [1]. In particular, the major
version is added to the URL and to the extracted GOPROXY provided
DISTFILE(s).

This change adjusts MASTER_SITES and WRKSRC with USES+= go to
support the "Major Version Suffixes" documented in the go module
docs [1].

  1. https://go.dev/ref/mod#major-version-suffixes

Signed-off-by: Enji Cooper <ngie@FreeBSD.org>

Test Plan

This change allows me to upgrade devel/golangci-lint to v2.0.2 . See D49724 for more details.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie requested review of this revision.Apr 9 2025, 2:26 AM
ngie created this revision.
Harbormaster completed remote builds in B63400: Diff 153379.Apr 9 2025, 2:26 AM
ngie edited the test plan for this revision. (Show Details)Apr 9 2025, 2:30 AM
ngie added reviewers: adamw, rene, mat, arrowd, tijl.
ngie mentioned this in D49724: devel/golangci-lint*: upgrade to 2.0.2 & fork/upgrade to 1.64.8.Apr 9 2025, 3:19 AM
arrowd accepted this revision.Apr 9 2025, 5:00 AM

Not a Go user, but semantically the change looks fine.

This revision is now accepted and ready to land.Apr 9 2025, 5:00 AM
adamw accepted this revision.Apr 9 2025, 2:35 PM

This is a good approach. I'm 👍 on behalf of the go team.

Thanks, Enji!

Closed by commit R11:0647dd427458: Mk/Uses/go.mk: support v2 and higher proxy URLs (authored by ngie). · Explain WhyApr 11 2025, 2:12 AM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: R11:0647dd427458: Mk/Uses/go.mk: support v2 and higher proxy URLs.
ngie added a comment.Apr 11 2025, 2:13 AM
In D49723#1133959, @adamw wrote:

This is a good approach. I'm 👍 on behalf of the go team.

Thanks, Enji!

Macro thankyou_dog:

adamw added a reverting change: R11:28a1c724e435: Uses/go.mk: Back out 0647dd427458993a2a4589467d8256998c0ee649.Apr 11 2025, 4:15 AM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
12 lines

Diff 153488

View Options

Mk/Uses/go.mk

Loading...