statfs.2: Document the new MNT_NAMEDATTR mount flag
ClosedPublic
Actions

Authored by rmacklem on Apr 8 2025, 10:12 PM.

Details

Reviewers

emaste
gbe
0mp

Group Reviewers

manpages

Commits

rG964d0fd62431: statfs.2: Update man page for the MNT_NAMEDATTR flag

Summary

Commit 2ec2ba7e232d added a new mount flag called
MNT_NAMEDATTR to indicate a mount supports named attributes.

This patch updates the man page for this flag.

Another man page that explains named attributes will
be introduced in a future commit.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rmacklem created this revision.Apr 8 2025, 10:12 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptApr 8 2025, 10:12 PM

rmacklem requested review of this revision.Apr 8 2025, 10:12 PM

ziaee added inline comments.Apr 8 2025, 10:29 PM

lib/libsys/statfs.2
178	These seem roughly alphabetized. Should we put this after line 127?

Moved the MNT_NAMEDATTR entry up, to maintain
alphabetical ordering, as suggested by ziaee@.

rmacklem marked an inline comment as done.Apr 9 2025, 8:05 PM

This looks sharp! The first sentence explains everything. Terse, informative, perfect. Personally, I do prefer that we keep metadata like the commit hash in commit trailers such as "Fixes:" and do the first sentence of commit messages the same way.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 1:03 AM

Closed by commit rG964d0fd62431: statfs.2: Update man page for the MNT_NAMEDATTR flag (authored by rmacklem). · Explain Why

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rG964d0fd62431: statfs.2: Update man page for the MNT_NAMEDATTR flag.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

	statfs.2
	statfs.2.xattr

8 lines

Diff 153427

View Options

statfs.2: Document the new MNT_NAMEDATTR mount flagClosedPublicActions