Differential D49650

ctld: Do not remove item from an nvlist while iterating it
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 7, 8:47 PM

	Unknown Object (File)
	Mon, Apr 6, 6:29 AM

	Unknown Object (File)
	Fri, Apr 3, 10:48 PM

	Unknown Object (File)
	Mar 11 2026, 11:59 PM

	Unknown Object (File)
	Feb 14 2026, 2:52 PM

	Unknown Object (File)
	Feb 1 2026, 8:21 AM

	Unknown Object (File)
	Jan 26 2026, 10:21 AM

	Unknown Object (File)
	Jan 26 2026, 12:32 AM

View All 68 Files

Subscribers

Details

Reviewers

Commits

rG4054439b47f2: ctld: Do not remove item from an nvlist while iterating it
rG30020689fb1e: ctld: Do not remove item from an nvlist while iterating it

Summary

While here, make use of cnvlist_* to simplify this code.

Fixes: d42a73fb6a85 ("ctld: Add a dedicated API between parse.y and the rest of the program")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63296
Build 60180: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 2 2025, 8:36 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:36 PM

jhb requested review of this revision.Apr 2 2025, 8:36 PM

Harbormaster completed remote builds in B63296: Diff 153054.Apr 2 2025, 8:36 PM

jhb added a parent revision: D49649: ctld: Remove dead logging code.Apr 2 2025, 8:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG30020689fb1e: ctld: Do not remove item from an nvlist while iterating it (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG30020689fb1e: ctld: Do not remove item from an nvlist while iterating it.

jhb added a commit: rG4054439b47f2: ctld: Do not remove item from an nvlist while iterating it.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

7 lines

Diff 153054

usr.sbin/ctld/kernel.cc

Loading...