ctld: Drop commented-out code to print the configuration
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:05 PM.

Details

Reviewers

Commits

rG8f799d4b1c71: ctld: Drop commented-out code to print the configuration
rG0708eb01f280: ctld: Drop commented-out code to print the configuration

Summary

This code is incomplete (it does not handle some of the options that
can be set) and easily rots since it is not enabled by default or
hooked up to anything that calls it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63291
Build 60175: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 2 2025, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:05 PM

jhb requested review of this revision.Apr 2 2025, 8:05 PM

Harbormaster completed remote builds in B63291: Diff 153045.Apr 2 2025, 8:05 PM

jhb added a parent revision: D49645: ctld: Properly validate mutual user/secret for CHAP-MUTUAL in the UCL parser.Apr 2 2025, 8:05 PM

jhb added a child revision: D49647: ctld: Tighten parsing of IPv6 addresses for initiator-portal.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG0708eb01f280: ctld: Drop commented-out code to print the configuration (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0708eb01f280: ctld: Drop commented-out code to print the configuration.

jhb added a commit: rG8f799d4b1c71: ctld: Drop commented-out code to print the configuration.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.cc

62 lines

Diff 153045

View Options

ctld: Drop commented-out code to print the configurationClosedPublicActions