Differential D49642

ctld: Reduce code duplication in auth_check_secret_length
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:04 PM.

Tags

None

Referenced Files

	F159883479: D49642.diff
	Fri, Jun 19, 2:39 AM

	Unknown Object (File)
	Apr 24 2026, 11:25 AM

	Unknown Object (File)
	Apr 23 2026, 6:15 PM

	Unknown Object (File)
	Apr 19 2026, 1:01 PM

	Unknown Object (File)
	Apr 19 2026, 12:23 PM

	Unknown Object (File)
	Apr 19 2026, 11:34 AM

	Unknown Object (File)
	Apr 18 2026, 7:50 PM

	Unknown Object (File)
	Apr 16 2026, 9:11 PM

View All 78 Files

Subscribers

Details

Reviewers

Commits

rG80888d8610ee: ctld: Reduce code duplication in auth_check_secret_length
rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length

Summary

Only check a single secret length in the function and call it twice
for the CHAP-MUTUAL case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63287
Build 60171: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 2 2025, 8:04 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:04 PM

jhb requested review of this revision.Apr 2 2025, 8:04 PM

Harbormaster completed remote builds in B63287: Diff 153041.Apr 2 2025, 8:04 PM

jhb added a parent revision: D49641: ctld: Fix sign bug validating kernel ports when reloading config.Apr 2 2025, 8:04 PM

jhb added a child revision: D49643: ctld: Add a label string to auth_groups.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length.

jhb added a commit: rG80888d8610ee: ctld: Reduce code duplication in auth_check_secret_length.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

67 lines

Diff 153041

usr.sbin/ctld/ctld.cc

Loading...