ctld: Fix sign bug validating kernel ports when reloading config
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:04 PM.

Details

Reviewers

Commits

rG9cdd58d51d49: ctld: Fix sign bug validating kernel ports when reloading config
rGe7611b7531c4: ctld: Fix sign bug validating kernel ports when reloading config

Summary

When I switched new_pports_from_conf to return bool instead of an
inverted int, I missed updating the call after reloading the config
file due to SIGHUP.

Fixes: 450a84c292ae ("ctld: Some bool-related cleanups")
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63286
Build 60170: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 2 2025, 8:04 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:04 PM

jhb requested review of this revision.Apr 2 2025, 8:04 PM

Harbormaster completed remote builds in B63286: Diff 153040.Apr 2 2025, 8:04 PM

jhb added a child revision: D49642: ctld: Reduce code duplication in auth_check_secret_length.Apr 2 2025, 8:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rGe7611b7531c4: ctld: Fix sign bug validating kernel ports when reloading config (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe7611b7531c4: ctld: Fix sign bug validating kernel ports when reloading config.

jhb added a commit: rG9cdd58d51d49: ctld: Fix sign bug validating kernel ports when reloading config.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.cc

2 lines

Diff 153040

View Options

ctld: Fix sign bug validating kernel ports when reloading configClosedPublicActions