Page MenuHomeFreeBSD
Differential D49333

device_pager: Assert that the handle is not NULL
ClosedPublic
Actions

Authored by jhb on Mar 12 2025, 7:58 PM.
Tags
None
Referenced Files
F173223493: D49333.id152228.diff
Thu, Sep 24, 10:56 AM
Unknown Object (File)
Wed, Sep 16, 7:24 AM
Unknown Object (File)
Wed, Sep 9, 3:15 PM
Unknown Object (File)
Tue, Sep 8, 1:55 AM
Unknown Object (File)
Sun, Sep 6, 10:54 AM
Unknown Object (File)
Sun, Sep 6, 3:30 AM
Unknown Object (File)
Sun, Sep 6, 3:11 AM
Unknown Object (File)
Sat, Sep 5, 7:16 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGf402078d0956: device_pager: Assert that the handle is not NULL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62890
Build 59774: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 12 2025, 7:58 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 12 2025, 7:58 PM
jhb requested review of this revision.Mar 12 2025, 7:58 PM
Harbormaster completed remote builds in B62890: Diff 152189.Mar 12 2025, 7:58 PM
jhb added a child revision: D49334: cdev: dev_copyname copies a character device's name to a buffer.Mar 12 2025, 7:58 PM
kib accepted this revision.Mar 12 2025, 10:06 PM
kib added inline comments.
sys/vm/device_pager.c
143

This check looks somewhat dubious for me. Might be it should be also converted into the assert.

This revision is now accepted and ready to land.Mar 12 2025, 10:06 PM
Closed by commit rGf402078d0956: device_pager: Assert that the handle is not NULL (authored by jhb). · Explain WhyMar 13 2025, 5:03 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGf402078d0956: device_pager: Assert that the handle is not NULL.

Revision Contents
Changeset List

PathSize
sys/
vm/
2 lines

Diff 152189

View Options

sys/vm/device_pager.c

Loading...