Differential D48968

gve: Fix qpl_buf_head being initialized improperly
ClosedPublic
Actions

Authored by jtranoleary_google.com on Wed, Feb 12, 6:16 PM.

Tags

None

Referenced Files

	F110246644: D48968.diff
	Sat, Feb 15, 4:45 PM

	F110178845: D48968.diff
	Fri, Feb 14, 5:04 PM

	Unknown Object (File)
	Fri, Feb 14, 3:05 PM

Subscribers

Details

Reviewers

markj
delphij
kibab
shailend_google.com

Group Reviewers

Commits

rG73c3fe4db3eb: gve: Fix qpl_buf_head being initialized improperly

Summary

Currently, for DQO QPL our MPASS assertion on qpl_buf_head for available
pending_pkts (i.e. not holding a packet) fails due to incorrect
initialization. The MPASS fails on the first run of packets through the
ring when INVARIANTS is on, and when INVARIANTS is off, things work
without a bug.

The MPASS guards against improper reaping of "pending_pkt" objects,
and thus was failing for the first run through the ring. By correctly
initializing the objects in this patch we make the MPASS not fail on the
first run too.

Signed-off-by: Vee Agarwal <veethebee@google.com>
Signed-off-by: Jasper Tran O'Leary <jtranoleary@google.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62432
Build 59316: arc lint + arc unit

Event Timeline

jtranoleary_google.com created this revision.Wed, Feb 12, 6:16 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 12, 6:16 PM

jtranoleary_google.com requested review of this revision.Wed, Feb 12, 6:16 PM

Harbormaster completed remote builds in B62399: Diff 150915.Wed, Feb 12, 6:16 PM

jtranoleary_google.com added a child revision: D48969: gve: Do minor cleanup and bump version.Wed, Feb 12, 6:16 PM

jtranoleary_google.com added a parent revision: D48970: gve: Fix memory leak during reset.Wed, Feb 12, 6:39 PM

delphij accepted this revision.Thu, Feb 13, 8:51 AM

This revision is now accepted and ready to land.Thu, Feb 13, 8:51 AM

markj accepted this revision as: markj.Thu, Feb 13, 2:46 PM

markj added inline comments.

sys/dev/gve/gve_tx_dqo.c
992	This line should be wrapped.

Add a line break to an overlong line

This revision now requires review to proceed.Thu, Feb 13, 10:43 PM

Harbormaster completed remote builds in B62432: Diff 150993.Thu, Feb 13, 10:43 PM

jtranoleary_google.com marked an inline comment as done.Thu, Feb 13, 10:44 PM

jtranoleary_google.com added inline comments.

sys/dev/gve/gve_tx_dqo.c
992	Done.

delphij accepted this revision.Fri, Feb 14, 9:12 AM

This revision is now accepted and ready to land.Fri, Feb 14, 9:12 AM

Closed by commit rG73c3fe4db3eb: gve: Fix qpl_buf_head being initialized improperly (authored by jtranoleary_google.com, committed by markj). · Explain WhyFri, Feb 14, 3:11 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG73c3fe4db3eb: gve: Fix qpl_buf_head being initialized improperly.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gve/

25 lines

Diff 150993

sys/dev/gve/gve_tx_dqo.c

Loading...