Page MenuHomeFreeBSD
Differential D48995

recv.2: Improve style in RETURN VALUES
ClosedPublic
Actions

Authored by ziaee on Feb 13 2025, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 23, 4:32 AM
Unknown Object (File)
Wed, Aug 20, 8:01 PM
Unknown Object (File)
Fri, Aug 15, 9:29 PM
Unknown Object (File)
Thu, Aug 14, 10:40 PM
Unknown Object (File)
Tue, Aug 12, 5:43 AM
Unknown Object (File)
Sat, Aug 9, 9:04 PM
Unknown Object (File)
Jul 21 2025, 3:32 AM
Unknown Object (File)
Jul 19 2025, 3:59 PM
View All 30 Files
Subscribers
felix.the.red_gmail.com
imp

Details

Reviewers
carlavilla
des
mhorne
Group Reviewers
manpages
Commits
rG6875767cf2e2: recv.2: Improve style in RETURN VALUES
rG7c3c8605d62f: recv.2: Improve style in RETURN VALUES
Summary

Reported by: des
MFC after: 3 days
Fixes: 571df2c64a3c1 (Explain how recv functions can)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62428
Build 59312: arc lint + arc unit

Revision Contents
Changeset List

PathSize
lib/
libsys/
6 lines

Diff 150985

View Options

lib/libsys/recv.2

Show All 36 Lines
#include <sys/mutex.h> #include <sys/mutex.h>
#include <sys/pcpu.h> #include <sys/pcpu.h>
#include <sys/proc.h> #include <sys/proc.h>
#include <sys/socket.h> #include <sys/socket.h>
#include <sys/socketvar.h> #include <sys/socketvar.h>
#include <sys/time.h> #include <sys/time.h>
#include <sys/uio.h> #include <sys/uio.h>
#include <netinet/tcp.h>
#include <rpc/rpc.h> #include <rpc/rpc.h>
#include <rpc/rpc_com.h> #include <rpc/rpc_com.h>
#include <rpc/krpc.h> #include <rpc/krpc.h>
#include <rpc/rpcsec_tls.h> #include <rpc/rpcsec_tls.h>
static enum clnt_stat clnt_reconnect_call(CLIENT *, struct rpc_callextra *, static enum clnt_stat clnt_reconnect_call(CLIENT *, struct rpc_callextra *,
rpcproc_t, struct mbuf *, struct mbuf **, struct timeval); rpcproc_t, struct mbuf *, struct mbuf **, struct timeval);
static void clnt_reconnect_geterr(CLIENT *, struct rpc_err *); static void clnt_reconnect_geterr(CLIENT *, struct rpc_err *);
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Linesclnt_reconnect_create(
rc->rc_retries = INT_MAX; rc->rc_retries = INT_MAX;
rc->rc_privport = FALSE; rc->rc_privport = FALSE;
rc->rc_waitchan = "rpcrecv"; rc->rc_waitchan = "rpcrecv";
rc->rc_intr = 0; rc->rc_intr = 0;
rc->rc_connecting = FALSE; rc->rc_connecting = FALSE;
rc->rc_closed = FALSE; rc->rc_closed = FALSE;
rc->rc_ucred = crdup(curthread->td_ucred); rc->rc_ucred = crdup(curthread->td_ucred);
rc->rc_client = NULL; rc->rc_client = NULL;
rc->rc_ddp = false;
rc->rc_tls = false; rc->rc_tls = false;
rc->rc_tlscertname = NULL; rc->rc_tlscertname = NULL;
rc->rc_reconcall = NULL; rc->rc_reconcall = NULL;
rc->rc_reconarg = NULL; rc->rc_reconarg = NULL;
cl->cl_refs = 1; cl->cl_refs = 1;
cl->cl_ops = &clnt_reconnect_ops; cl->cl_ops = &clnt_reconnect_ops;
cl->cl_private = (caddr_t)(void *)rc; cl->cl_private = (caddr_t)(void *)rc;
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines if (rc->rc_tls && newclient != NULL) {
rpc_createerr.cf_error.re_errno = 0; rpc_createerr.cf_error.re_errno = 0;
CLNT_CLOSE(newclient); CLNT_CLOSE(newclient);
CLNT_RELEASE(newclient); CLNT_RELEASE(newclient);
newclient = NULL; newclient = NULL;
td->td_ucred = oldcred; td->td_ucred = oldcred;
goto out; goto out;
} }
} }
if (rc->rc_ddp && newclient != NULL) {
int optval = 1;
(void)so_setsockopt(so, IPPROTO_TCP, TCP_USE_DDP,
&optval, sizeof(optval));
}
rmacklemUnsubmitted
Not Done
Inline Actions

Normally the clnt_rc.c (reconnect layer) would
do a CLSET_TCP_DDP and the so_setsockopt()
would be done for CLSET_TCP_DDP in clnt_vc.c
and ignored in clnt_dg.c.

I've never been much of an object oriented guy,
but the Sun folk loved these layers.

rmacklem: Normally the clnt_rc.c (reconnect layer) would do a CLSET_TCP_DDP and the so_setsockopt() would…
if (newclient != NULL && rc->rc_reconcall != NULL) if (newclient != NULL && rc->rc_reconcall != NULL)
(*rc->rc_reconcall)(newclient, rc->rc_reconarg, (*rc->rc_reconcall)(newclient, rc->rc_reconarg,
rc->rc_ucred); rc->rc_ucred);
} }
td->td_ucred = oldcred; td->td_ucred = oldcred;
if (!newclient) { if (!newclient) {
soclose(so); soclose(so);
▲ Show 20 Lines • Show All 292 Lines • ▼ Show 20 Lines case CLSET_TLSCERTNAME:
rc->rc_tlscertname = mem_alloc(slen); rc->rc_tlscertname = mem_alloc(slen);
strlcpy(rc->rc_tlscertname, info, slen); strlcpy(rc->rc_tlscertname, info, slen);
break; break;
case CLSET_RECONUPCALL: case CLSET_RECONUPCALL:
upcp = (struct rpc_reconupcall *)info; upcp = (struct rpc_reconupcall *)info;
rc->rc_reconcall = upcp->call; rc->rc_reconcall = upcp->call;
rc->rc_reconarg = upcp->arg; rc->rc_reconarg = upcp->arg;
break;
case CLSET_DDP:
rc->rc_ddp = true;
break; break;
default: default:
return (FALSE); return (FALSE);
} }
return (TRUE); return (TRUE);
} }
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines