Differential D48933

ctld: Fix parsing of text values for DSCP in UCL parser
ClosedPublic
Actions

Authored by jhb on Feb 11 2025, 1:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 29, 12:21 AM

	Unknown Object (File)
	Tue, Nov 18, 12:31 PM

	Unknown Object (File)
	Tue, Nov 4, 2:45 AM

	Unknown Object (File)
	Tue, Nov 4, 2:45 AM

	Unknown Object (File)
	Tue, Nov 4, 2:45 AM

	Unknown Object (File)
	Tue, Nov 4, 2:44 AM

	Unknown Object (File)
	Sat, Nov 1, 7:19 PM

	Unknown Object (File)
	Sat, Nov 1, 3:06 PM

View All 67 Files

Subscribers

Details

Reviewers

Commits

rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62360
Build 59244: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 11 2025, 1:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 1:20 AM

Harbormaster completed remote builds in B62360: Diff 150822.Feb 11 2025, 1:20 AM

jhb requested review of this revision.Feb 11 2025, 1:20 AM

jhb added a parent revision: D48932: ctld: Use preferred style for evaluating result of strcmp.

jhb added a child revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.

The old code certainly looks broken. I guess nobody was using it?

This revision is now accepted and ready to land.Feb 11 2025, 6:35 PM

In D48933#1116308, @asomers wrote:

The old code certainly looks broken. I guess nobody was using it?

Yes, my guess is that the UCL paths weren't well tested.

Closed by commit rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser (authored by jhb). · Explain WhyFeb 12 2025, 7:35 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

44 lines

Diff 150822

usr.sbin/ctld/uclparse.c

Loading...