Differential D48932

ctld: Use preferred style for evaluating result of strcmp
ClosedPublic
Actions

Authored by jhb on Feb 11 2025, 1:20 AM.

Tags

None

Referenced Files

	F175361726: D48932.id150924.diff
	Sat, Oct 10, 7:15 AM

	Unknown Object (File)
	Mon, Oct 5, 9:01 AM

	Unknown Object (File)
	Sat, Oct 3, 8:51 PM

	Unknown Object (File)
	Thu, Oct 1, 7:12 AM

	Unknown Object (File)
	Aug 13 2026, 1:47 AM

	Unknown Object (File)
	Aug 10 2026, 4:49 PM

	Unknown Object (File)
	Aug 8 2026, 11:17 PM

	Unknown Object (File)
	Aug 8 2026, 6:07 PM

View All 97 Files

Subscribers

Details

Reviewers

Commits

rGe7b94c2f3fa2: ctld: Use preferred style for evaluating result of strcmp
rG79a4240b1359: ctld: Use preferred style for evaluating result of strcmp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62359
Build 59243: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 11 2025, 1:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 1:20 AM

jhb requested review of this revision.Feb 11 2025, 1:20 AM

Harbormaster completed remote builds in B62359: Diff 150821.Feb 11 2025, 1:20 AM

jhb added a parent revision: D48931: ctld: Fail for missing or invalid CHAP secrets in UCL config.Feb 11 2025, 1:20 AM

jhb added a child revision: D48933: ctld: Fix parsing of text values for DSCP in UCL parser.

It's frustrating that file parsing is so difficult in C.

This revision is now accepted and ready to land.Feb 11 2025, 6:24 PM

Closed by commit rG79a4240b1359: ctld: Use preferred style for evaluating result of strcmp (authored by jhb). · Explain WhyFeb 12 2025, 7:35 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG79a4240b1359: ctld: Use preferred style for evaluating result of strcmp.

jhb added a commit: rGe7b94c2f3fa2: ctld: Use preferred style for evaluating result of strcmp.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

86 lines

Diff 150821

usr.sbin/ctld/uclparse.c

Loading...